colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xilinx: common: Use strlcpy instead of strncpy

Browse Source 
It is recommendation done by checkpatch to all the time have \0 terminated
strings.

Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/c7bfab50c40f6213f1b347b5e4674e382e83cb94.1658413156.git.michal.simek@amd.com
This commit is contained in:
Michal Simek
2022-07-21 16:19:18 +02:00
parent ee5a4b87a1
commit 4a1bfcd7aa
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
board/xilinx/common/board.c
View File

@@ -238,23 +238,23 @@ static int xilinx_read_eeprom_fru(struct udevice *dev, char *name,
} }
/* It is clear that FRU was captured and structures were filled */ /* It is clear that FRU was captured and structures were filled */
strncpy(desc->manufacturer, (char *)fru_data.brd.manufacturer_name, strlcpy(desc->manufacturer, (char *)fru_data.brd.manufacturer_name,
sizeof(desc->manufacturer)); sizeof(desc->manufacturer));
strncpy(desc->uuid, (char *)fru_data.brd.uuid, strlcpy(desc->uuid, (char *)fru_data.brd.uuid,
sizeof(desc->uuid)); sizeof(desc->uuid));
strncpy(desc->name, (char *)fru_data.brd.product_name, strlcpy(desc->name, (char *)fru_data.brd.product_name,
sizeof(desc->name)); sizeof(desc->name));
for (i = 0; i < sizeof(desc->name); i++) { for (i = 0; i < sizeof(desc->name); i++) {
if (desc->name[i] == ' ') if (desc->name[i] == ' ')
desc->name[i] = '\0'; desc->name[i] = '\0';
} }
strncpy(desc->revision, (char *)fru_data.brd.rev, strlcpy(desc->revision, (char *)fru_data.brd.rev,
sizeof(desc->revision)); sizeof(desc->revision));
for (i = 0; i < sizeof(desc->revision); i++) { for (i = 0; i < sizeof(desc->revision); i++) {
if (desc->revision[i] == ' ') if (desc->revision[i] == ' ')
desc->revision[i] = '\0'; desc->revision[i] = '\0';
} }
strncpy(desc->serial, (char *)fru_data.brd.serial_number, strlcpy(desc->serial, (char *)fru_data.brd.serial_number,
sizeof(desc->serial)); sizeof(desc->serial));
while (id < EEPROM_HDR_NO_OF_MAC_ADDR) { while (id < EEPROM_HDR_NO_OF_MAC_ADDR) {