colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

efi_loader: simplify error message in efi_disk_create_raw()

Browse Source 
The error message

    Adding disk for usb_mass_storage.lun0 failed (err=-9223372036854775788/0x8000000000000014)

provides a decimal and a hexadecimal notation of the EFI status code
EFI_ALREADY_STARTED which is defined as (EFI_ERROR_MASK | 20).
The decimal output does not convey the value 20 clearly.

With the patch we write

    Adding block device usb_mass_storage.lun0 failed, r = 20

similar to other EFI error messages.

Fixes: 952018117a ("dm: sandbox: Switch over to using the new host uclass")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Heinrich Schuchardt
2024-02-02 15:12:52 +01:00
parent 5bf0802631
commit 50457f547d
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/efi_loader/efi_disk.c
View File

@@ -574,7 +574,8 @@ static int efi_disk_create_raw(struct udevice *dev, efi_handle_t agent_handle)
log_notice("Disk %s not ready\n", dev->name);
ret = -EBUSY;
} else {
log_err("Adding disk for %s failed (err=%ld/%#lx)\n", dev->name, ret, ret);
log_err("Adding block device %s failed, r = %lu\n",
dev->name, ret & ~EFI_ERROR_MASK);
ret = -ENOENT;
}