efi_selftest: add tests for QueryVariableInfo at runtime
Since we support QueryVariableInfo at runtime now add the relevant tests. Since we want those to be reusable at bootime, add them in a separate file Add tests for - Test QueryVariableInfo returns EFI_SUCCESS - Test null pointers for the function arguments - Test invalid combination of attributes Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This commit is contained in:

committed by
Heinrich Schuchardt

parent
9677192c14
commit
6b2aaf8d03
@@ -147,6 +147,17 @@ void *efi_st_get_config_table(const efi_guid_t *guid);
|
|||||||
*/
|
*/
|
||||||
u16 efi_st_get_key(void);
|
u16 efi_st_get_key(void);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* efi_st_query_variable_common - Common variable tests for boottime/runtime
|
||||||
|
*
|
||||||
|
* @runtime: Pointer to services table
|
||||||
|
* @attributes: Attributes used
|
||||||
|
*
|
||||||
|
* Return: EFI_ST_SUCCESS/FAILURE
|
||||||
|
*/
|
||||||
|
int efi_st_query_variable_common(struct efi_runtime_services *runtime,
|
||||||
|
u32 attributes);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* struct efi_unit_test - EFI unit test
|
* struct efi_unit_test - EFI unit test
|
||||||
*
|
*
|
||||||
|
@@ -45,6 +45,7 @@ efi_selftest_textinputex.o \
|
|||||||
efi_selftest_textoutput.o \
|
efi_selftest_textoutput.o \
|
||||||
efi_selftest_tpl.o \
|
efi_selftest_tpl.o \
|
||||||
efi_selftest_util.o \
|
efi_selftest_util.o \
|
||||||
|
efi_selftest_variables_common.o \
|
||||||
efi_selftest_variables.o \
|
efi_selftest_variables.o \
|
||||||
efi_selftest_variables_runtime.o \
|
efi_selftest_variables_runtime.o \
|
||||||
efi_selftest_watchdog.o
|
efi_selftest_watchdog.o
|
||||||
|
99
lib/efi_selftest/efi_selftest_variables_common.c
Normal file
99
lib/efi_selftest/efi_selftest_variables_common.c
Normal file
@@ -0,0 +1,99 @@
|
|||||||
|
// SPDX-License-Identifier: GPL-2.0+
|
||||||
|
/*
|
||||||
|
* efi_selftest_variables_runtime
|
||||||
|
*
|
||||||
|
* Copyright (c) 2024 Ilias Apalodimas <ilias.apalodimas@linaro.org>
|
||||||
|
*
|
||||||
|
* This unit test checks common service across boottime/runtime
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <efi_selftest.h>
|
||||||
|
|
||||||
|
#define EFI_INVALID_ATTR BIT(30)
|
||||||
|
|
||||||
|
int efi_st_query_variable_common(struct efi_runtime_services *runtime,
|
||||||
|
u32 attributes)
|
||||||
|
{
|
||||||
|
efi_status_t ret;
|
||||||
|
u64 max_storage, rem_storage, max_size;
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(attributes,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_SUCCESS) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(EFI_VARIABLE_RUNTIME_ACCESS,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(attributes,
|
||||||
|
NULL, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(attributes,
|
||||||
|
&max_storage, NULL,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(attributes,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
NULL);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(0, &max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(attributes |
|
||||||
|
EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS |
|
||||||
|
EFI_VARIABLE_NON_VOLATILE,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_UNSUPPORTED) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
ret = runtime->query_variable_info(EFI_VARIABLE_NON_VOLATILE,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Use a mix existing/non-existing attribute bits from the
|
||||||
|
* UEFI spec
|
||||||
|
*/
|
||||||
|
ret = runtime->query_variable_info(attributes | EFI_INVALID_ATTR |
|
||||||
|
EFI_VARIABLE_NON_VOLATILE,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
|
if (ret != EFI_INVALID_PARAMETER) {
|
||||||
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
|
return EFI_ST_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
return EFI_ST_SUCCESS;
|
||||||
|
}
|
@@ -55,18 +55,21 @@ static int execute(void)
|
|||||||
u16 varname[EFI_ST_MAX_VARNAME_SIZE];
|
u16 varname[EFI_ST_MAX_VARNAME_SIZE];
|
||||||
efi_guid_t guid;
|
efi_guid_t guid;
|
||||||
u64 max_storage, rem_storage, max_size;
|
u64 max_storage, rem_storage, max_size;
|
||||||
|
int test_ret;
|
||||||
|
|
||||||
memset(v2, 0x1, sizeof(v2));
|
memset(v2, 0x1, sizeof(v2));
|
||||||
ret = runtime->query_variable_info(EFI_VARIABLE_BOOTSERVICE_ACCESS,
|
|
||||||
&max_storage, &rem_storage,
|
|
||||||
&max_size);
|
|
||||||
|
|
||||||
if (IS_ENABLED(CONFIG_EFI_VARIABLE_FILE_STORE)) {
|
if (IS_ENABLED(CONFIG_EFI_VARIABLE_FILE_STORE)) {
|
||||||
if (ret != EFI_SUCCESS) {
|
test_ret = efi_st_query_variable_common(runtime, EFI_VARIABLE_BOOTSERVICE_ACCESS |
|
||||||
|
EFI_VARIABLE_RUNTIME_ACCESS);
|
||||||
|
if (test_ret != EFI_ST_SUCCESS) {
|
||||||
efi_st_error("QueryVariableInfo failed\n");
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
return EFI_ST_FAILURE;
|
return EFI_ST_FAILURE;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
|
ret = runtime->query_variable_info(EFI_VARIABLE_BOOTSERVICE_ACCESS,
|
||||||
|
&max_storage, &rem_storage,
|
||||||
|
&max_size);
|
||||||
if (ret != EFI_UNSUPPORTED) {
|
if (ret != EFI_UNSUPPORTED) {
|
||||||
efi_st_error("QueryVariableInfo failed\n");
|
efi_st_error("QueryVariableInfo failed\n");
|
||||||
return EFI_ST_FAILURE;
|
return EFI_ST_FAILURE;
|
||||||
|
Reference in New Issue
Block a user