colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: msm: return correct value return for special output pins

Browse Source 
When a special pin is output only, the current code would return 0,
but if the pin is output only we can get the output value.

Try to return the output value and in all the other cases return
an error instead of 0.

Fixes: f9bb539460 ("gpio: msm: add support for special pins")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250401-topic-sm8x50-msm-gpio-special-fixes-v1-2-a1148a02bb16@linaro.org
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
This commit is contained in:
Neil Armstrong
2025-04-01 09:45:20 +02:00
committed by Caleb Connolly
parent 0708bdd34d
commit 8803cd6dd7
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/gpio/msm_gpio.c
View File

@@ -172,12 +172,19 @@ static int msm_gpio_get_value_special(struct msm_gpio_bank *priv, unsigned int g
const struct msm_special_pin_data *data; const struct msm_special_pin_data *data;
if (!priv->pin_data->special_pins_data) if (!priv->pin_data->special_pins_data)
return 0; return -EINVAL;
data = &priv->pin_data->special_pins_data[offset]; data = &priv->pin_data->special_pins_data[offset];
if (!data->io_reg || data->in_bit >= 31) if (!data->io_reg)
return 0; return -EINVAL;
if (data->in_bit >= 31) {
if (data->out_bit >= 31)
return -EINVAL;
return !!(readl(priv->base + data->io_reg) >> data->out_bit);
}
return !!(readl(priv->base + data->io_reg) >> data->in_bit); return !!(readl(priv->base + data->io_reg) >> data->in_bit);
} }