colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: eth-phy: use dev_dbg and log_notice

Browse Source 
Replace debug trace and printf to log macros:
- debug() replaced by dev_dbg() when device is available, this macro
indicate the device name since commit ceb70bb870 ("dm: Print device
name in dev_xxx like Linux")
- printf() replaced by log_notice() to allow  dispatch to log backends.

Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
This commit is contained in:
Patrick Delaunay
2021-07-20 20:09:52 +02:00
committed by Ramon Fried
parent d33982d5bc
commit 880ecb09b9
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/net/eth-phy-uclass.c
View File

@@ -5,8 +5,10 @@
#include <common.h> #include <common.h>
#include <dm.h> #include <dm.h>
#include <log.h>
#include <net.h> #include <net.h>
#include <asm-generic/gpio.h> #include <asm-generic/gpio.h>
#include <dm/device_compat.h>
#include <dm/device-internal.h> #include <dm/device-internal.h>
#include <dm/uclass-internal.h> #include <dm/uclass-internal.h>
#include <dm/lists.h> #include <dm/lists.h>
@@ -27,25 +29,25 @@ int eth_phy_binds_nodes(struct udevice *eth_dev)
mdio_node = dev_read_subnode(eth_dev, "mdio"); mdio_node = dev_read_subnode(eth_dev, "mdio");
if (!ofnode_valid(mdio_node)) { if (!ofnode_valid(mdio_node)) {
debug("%s: %s mdio subnode not found!", __func__, dev_dbg(eth_dev, "%s: %s mdio subnode not found!", __func__,
eth_dev->name); eth_dev->name);
return -ENXIO; return -ENXIO;
} }
ofnode_for_each_subnode(phy_node, mdio_node) { ofnode_for_each_subnode(phy_node, mdio_node) {
node_name = ofnode_get_name(phy_node); node_name = ofnode_get_name(phy_node);
debug("* Found child node: '%s'\n", node_name); dev_dbg(eth_dev, "* Found child node: '%s'\n", node_name);
ret = device_bind_driver_to_node(eth_dev, ret = device_bind_driver_to_node(eth_dev,
"eth_phy_generic_drv", "eth_phy_generic_drv",
node_name, phy_node, NULL); node_name, phy_node, NULL);
if (ret) { if (ret) {
debug(" - Eth phy binding error: %d\n", ret); dev_dbg(eth_dev, " - Eth phy binding error: %d\n", ret);
continue; continue;
} }
debug(" - bound phy device: '%s'\n", node_name); dev_dbg(eth_dev, " - bound phy device: '%s'\n", node_name);
} }
return 0; return 0;
@@ -86,14 +88,14 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev)
*/ */
uc_priv = (struct eth_phy_device_priv *)(dev_get_uclass_priv(phy_dev)); uc_priv = (struct eth_phy_device_priv *)(dev_get_uclass_priv(phy_dev));
if (uc_priv->mdio_bus) if (uc_priv->mdio_bus)
printf("Get shared mii bus on %s\n", eth_dev->name); log_notice("Get shared mii bus on %s\n", eth_dev->name);
else else
printf("Can't get shared mii bus on %s\n", eth_dev->name); log_notice("Can't get shared mii bus on %s\n", eth_dev->name);
return uc_priv->mdio_bus; return uc_priv->mdio_bus;
} }
} else { } else {
printf("FEC: can't find phy-handle\n"); log_notice("FEC: can't find phy-handle\n");
} }
return NULL; return NULL;
@@ -106,7 +108,7 @@ int eth_phy_get_addr(struct udevice *dev)
if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
&phandle_args)) { &phandle_args)) {
debug("Failed to find phy-handle"); dev_dbg(dev, "Failed to find phy-handle");
return -ENODEV; return -ENODEV;
} }