colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arm: mvebu: a38x: Call bb_miiphy init directly in driver probe

Browse Source 
All the resources needed by this .init callback should already
be available by the time probe function runs, simply call the
init callback directly and set the bb_miiphy init callback to
NULL. This shouldn't break anything on this hardware, but would
be nice if someone could double-check and test that.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
This commit is contained in:
Marek Vasut
2025-02-22 21:33:18 +01:00
parent bc8d7288e3
commit b6e76cff08
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
board/gdsys/a38x/ihs_phys.c
View File

@@ -236,7 +236,7 @@ int register_miiphy_bus(uint k, struct mii_dev **bus)
return retval; return retval;
*bus = miiphy_get_dev_by_name(name); *bus = miiphy_get_dev_by_name(name);
return 0; return mii_mdio_init(&bb_miiphy_buses[k]);
} }
struct porttype *get_porttype(uint octo_phy_mask, uint k) struct porttype *get_porttype(uint octo_phy_mask, uint k)
@@ -318,7 +318,6 @@ int init_octo_phys(uint octo_phy_mask)
struct bb_miiphy_bus bb_miiphy_buses[] = { struct bb_miiphy_bus bb_miiphy_buses[] = {
{ {
.name = "ihs0", .name = "ihs0",
.init = mii_mdio_init,
.mdio_active = mii_mdio_active, .mdio_active = mii_mdio_active,
.mdio_tristate = mii_mdio_tristate, .mdio_tristate = mii_mdio_tristate,
.set_mdio = mii_set_mdio, .set_mdio = mii_set_mdio,
@@ -329,7 +328,6 @@ struct bb_miiphy_bus bb_miiphy_buses[] = {
}, },
{ {
.name = "ihs1", .name = "ihs1",
.init = mii_mdio_init,
.mdio_active = mii_mdio_active, .mdio_active = mii_mdio_active,
.mdio_tristate = mii_mdio_tristate, .mdio_tristate = mii_mdio_tristate,
.set_mdio = mii_set_mdio, .set_mdio = mii_set_mdio,
@@ -340,7 +338,6 @@ struct bb_miiphy_bus bb_miiphy_buses[] = {
}, },
{ {
.name = "ihs2", .name = "ihs2",
.init = mii_mdio_init,
.mdio_active = mii_mdio_active, .mdio_active = mii_mdio_active,
.mdio_tristate = mii_mdio_tristate, .mdio_tristate = mii_mdio_tristate,
.set_mdio = mii_set_mdio, .set_mdio = mii_set_mdio,