treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:

committed by
Tom Rini

parent
02ff91e8c6
commit
b75d8dc564
@@ -6,6 +6,6 @@
|
||||
#ifndef ASM_ARCH_MXCMMC_H
|
||||
#define ASM_ARCH_MXCMMC_H
|
||||
|
||||
int mxc_mmc_init(bd_t *bis);
|
||||
int mxc_mmc_init(struct bd_info *bis);
|
||||
|
||||
#endif
|
||||
|
@@ -16,5 +16,5 @@ struct mxc_weimcs {
|
||||
};
|
||||
|
||||
void mxc_setup_weimcs(int cs, const struct mxc_weimcs *weimcs);
|
||||
int mxc_mmc_init(bd_t *bis);
|
||||
int mxc_mmc_init(struct bd_info *bis);
|
||||
#endif
|
||||
|
@@ -6,7 +6,7 @@
|
||||
#ifndef __ARCH_ARM_MX6UL_LITESOM_H__
|
||||
#define __ARCH_ARM_MX6UL_LITESOM_H__
|
||||
|
||||
int litesom_mmc_init(bd_t *bis);
|
||||
int litesom_mmc_init(struct bd_info *bis);
|
||||
|
||||
#ifdef CONFIG_SPL_BUILD
|
||||
void litesom_init_f(void);
|
||||
|
@@ -11,7 +11,8 @@
|
||||
|
||||
#include <asm/mach-imx/sys_proto.h>
|
||||
|
||||
int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int), int (*cd)(int));
|
||||
int mxsmmc_initialize(struct bd_info *bis, int id, int (*wp)(int),
|
||||
int (*cd)(int));
|
||||
|
||||
#ifdef CONFIG_SPL_BUILD
|
||||
|
||||
|
Reference in New Issue
Block a user