colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

treewide: convert bd_t to struct bd_info by coccinelle

Browse Source 
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:

  It's a **mistake** to use typedef for structures and pointers.

Besides, using typedef for structures is annoying when you try to make
headers self-contained.

Let's say you have the following function declaration in a header:

  void foo(bd_t *bd);

This is not self-contained since bd_t is not defined.

To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>

  #include <asm/u-boot.h>
  void foo(bd_t *bd);

Then, the include direcective pulls in more bloat needlessly.

If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:

  struct bd_info;
  void foo(struct bd_info *bd);

Right, typedef'ing bd_t is a mistake.

I used coccinelle to generate this commit.

The semantic patch that makes this change is as follows:

  <smpl>
  @@
  typedef bd_t;
  @@
  -bd_t
  +struct bd_info
  </smpl>

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada
2020-06-26 15:13:33 +09:00
committed by Tom Rini
parent 02ff91e8c6
commit b75d8dc564
489 changed files with 801 additions and 784 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/rtl8139.c
View File

@@ -564,7 +564,7 @@ static int rtl8139_bcast_addr(struct eth_device *dev, const u8 *bcast_mac,
return 0;
}
static int rtl8139_init(struct eth_device *dev, bd_t *bis)
static int rtl8139_init(struct eth_device *dev, struct bd_info *bis)
{
struct rtl8139_priv *priv = container_of(dev, struct rtl8139_priv, dev);
@@ -601,7 +601,7 @@ static int rtl8139_recv(struct eth_device *dev)
return ret;
}
int rtl8139_initialize(bd_t *bis)
int rtl8139_initialize(struct bd_info *bis)
{
struct rtl8139_priv *priv;
struct eth_device *dev;