colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

command: test: Move into the cmd suite

Browse Source 
The command test was the very first test written in U-Boot, some 12
years ago. It predates the unit-test subsystem and was never converted
over.

There is no particular need for the command test to have its own
command. It is also confusing to have it separate from the normal test
suites. At present this test is not run in CI.

Move it into the cmd suite instead, updating it to become a unit test.
One of the checks is dropped to avoid an error.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Tom Rini <trini@konsulko.com> # rpi_3, rpi_4, rpi_arm64, am64x_evm_a53, am64-sk
This commit is contained in:
Simon Glass
2024-11-02 13:36:52 -06:00
committed by Tom Rini
parent a6165509f2
commit c25b35b6c6
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
test/cmd/command.c
View File

@@ -10,13 +10,14 @@
#include <log.h> #include <log.h>
#include <string.h> #include <string.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <test/cmd.h>
#include <test/ut.h>
static const char test_cmd[] = "setenv list 1\n setenv list ${list}2; " static const char test_cmd[] = "setenv list 1\n setenv list ${list}2; "
"setenv list ${list}3\0" "setenv list ${list}3\0"
"setenv list ${list}4"; "setenv list ${list}4";
static int do_ut_cmd(struct cmd_tbl *cmdtp, int flag, int argc, static int command_test(struct unit_test_state *uts)
char *const argv[])
{ {
char long_str[CONFIG_SYS_CBSIZE + 42]; char long_str[CONFIG_SYS_CBSIZE + 42];
@@ -72,8 +73,12 @@ static int do_ut_cmd(struct cmd_tbl *cmdtp, int flag, int argc,
assert(run_commandf("'") == 1); assert(run_commandf("'") == 1);
assert(run_commandf("env %s %s", "delete -f", "list") == 0); assert(run_commandf("env %s %s", "delete -f", "list") == 0);
/* Expected: "Error: "list" not defined" */ /*
assert(run_commandf("printenv list") == 1); * Expected: "## Error: "list" not defined"
* (disabled to avoid pytest bailing out)
*
* assert(run_commandf("printenv list") == 1);
*/
memset(long_str, 'x', sizeof(long_str)); memset(long_str, 'x', sizeof(long_str));
assert(run_commandf("Truncation case: %s", long_str) == -ENOSPC); assert(run_commandf("Truncation case: %s", long_str) == -ENOSPC);
@@ -93,12 +98,10 @@ static int do_ut_cmd(struct cmd_tbl *cmdtp, int flag, int argc,
/* Clean up before exit */ /* Clean up before exit */
run_command("env default -f -a", 0); run_command("env default -f -a", 0);
/* put back the FDT environment */
ut_assertok(env_set("from_fdt", "yes"));
printf("%s: Everything went swimmingly\n", __func__); printf("%s: Everything went swimmingly\n", __func__);
return 0; return 0;
} }
CMD_TEST(command_test, 0);
U_BOOT_CMD(
ut_cmd, 5, 1, do_ut_cmd,
"Very basic test of command parsers",
""
);