lmb: add a check to prevent memory overrun
When printing the LMB flags for a memory region, there is a need to check that the array index that is computed is a sane value. Put a noisy assert in case this check fails, as that implies something with the LMB code is not working as expected. Reported-by: Coverity (CID 510463) Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
This commit is contained in:
@@ -76,6 +76,7 @@ static void lmb_print_region_flags(enum lmb_flags flags)
|
|||||||
|
|
||||||
do {
|
do {
|
||||||
bitpos = flags ? fls(flags) - 1 : 0;
|
bitpos = flags ? fls(flags) - 1 : 0;
|
||||||
|
assert_noisy(bitpos < ARRAY_SIZE(flag_str));
|
||||||
printf("%s", flag_str[bitpos]);
|
printf("%s", flag_str[bitpos]);
|
||||||
flags &= ~(1ull << bitpos);
|
flags &= ~(1ull << bitpos);
|
||||||
puts(flags ? ", " : "\n");
|
puts(flags ? ", " : "\n");
|
||||||
|
Reference in New Issue
Block a user