colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net-lwip: zero terminate string with headers in wget_lwip_fill_info()

Browse Source 
This patch comes as a companion to the same patch but for the legacy
    net stack. Commit 1327c2a8d6 ("net/lwip: wget: integrate struct wget_info
    into wget code") introduced function wget_fill_info() which retrieves
    the headers from the HTTP server response. As we want to parse the
    string in later patches we need to ensure that it is NUL terminated.

    We must further check that wget_info->headers in not NULL.
    Otherwise a crash occurs.

Signed-off-by: Adriano Cordova <adrianox@gmail.com>
This commit is contained in:
Adriano Cordova
2024-11-26 13:19:21 -03:00
committed by Heinrich Schuchardt
parent 737c2dca95
commit dc7c8a2532
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
net/lwip/wget.c
View File

@@ -40,8 +40,13 @@ struct wget_ctx {
static void wget_lwip_fill_info(struct pbuf *hdr, u16_t hdr_len, u32_t hdr_cont_len) static void wget_lwip_fill_info(struct pbuf *hdr, u16_t hdr_len, u32_t hdr_cont_len)
{ {
if (wget_info->headers && hdr_len < MAX_HTTP_HEADERS_SIZE) if (wget_info->headers) {
pbuf_copy_partial(hdr, (void *)wget_info->headers, hdr_len, 0); if (hdr_len < MAX_HTTP_HEADERS_SIZE)
pbuf_copy_partial(hdr, (void *)wget_info->headers, hdr_len, 0);
else
hdr_len = 0;
wget_info->headers[hdr_len] = 0;
}
wget_info->hdr_cont_len = (u32)hdr_cont_len; wget_info->hdr_cont_len = (u32)hdr_cont_len;
} }