colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkpatch.pl: Request if() instead #ifdef

Browse Source 
There is a lot of use of #ifdefs in U-Boot. In an effort reduce this,
suggest using the compile-time construct.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass
2020-05-22 16:32:40 -06:00
committed by Tom Rini
parent 58978114d9
commit dd5b0fad8f
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/checkpatch.pl
View File

@@ -2261,6 +2261,12 @@ sub u_boot_line {
WARN("CMD_TEST", WARN("CMD_TEST",
"Possible new command - make sure you add a test\n" . $herecurr); "Possible new command - make sure you add a test\n" . $herecurr);
} }
# use if instead of #if
if ($line =~ /^\+#if.*CONFIG.*/) {
WARN("PREFER_IF",
"Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible\n" . $herecurr);
}
} }
sub process { sub process {