colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sandbox: Unmap old tags

Browse Source 
So far unmapping has not been implemented. This means that if one test
maps a pointer to an address with map_sysmem(), then a second test can
use that same pointer, by mapping the address back to a pointer with
map_to_sysmem(). This is not really desirable, even if it doesn't
cause any problems at the moment.

Implement unmapping, to clean this up.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass
2024-09-01 16:26:25 -06:00
committed by Tom Rini
parent 58f26a17b4
commit e82baf0801
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
arch/sandbox/cpu/cpu.c
View File

@@ -185,12 +185,28 @@ void *map_physmem(phys_addr_t paddr, unsigned long len, unsigned long flags)
void unmap_physmem(const void *ptr, unsigned long flags) void unmap_physmem(const void *ptr, unsigned long flags)
{ {
struct sandbox_mapmem_entry *mentry;
#ifdef CONFIG_PCI #ifdef CONFIG_PCI
if (map_dev) { if (map_dev) {
pci_unmap_physmem(ptr, map_len, map_dev); pci_unmap_physmem(ptr, map_len, map_dev);
map_dev = NULL; map_dev = NULL;
} }
#endif #endif
/* If it is in emulated RAM, we didn't create a tag, so nothing to do */
if (is_in_sandbox_mem(ptr))
return;
mentry = find_tag(ptr);
if (mentry) {
list_del(&mentry->sibling_node);
log_debug("Removed map from %p to %lx\n", ptr,
(ulong)mentry->tag);
free(mentry);
} else {
log_warning("Address not mapped: %p\n", ptr);
}
} }
phys_addr_t map_to_sysmem(const void *ptr) phys_addr_t map_to_sysmem(const void *ptr)