colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hush: avoid NULL check before free()

Browse Source 
free() checks if its argument is NULL. Don't duplicate this in the calling
code.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Heinrich Schuchardt
2020-04-28 21:56:10 +02:00
committed by Tom Rini
parent 4fb0f55fd2
commit f4070e6f6c
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
common/cli_hush.c
View File

@@ -1849,8 +1849,7 @@ static int run_list_real(struct pipe *pi)
continue; continue;
} else { } else {
/* insert new value from list for variable */ /* insert new value from list for variable */
if (pi->progs->argv[0]) free(pi->progs->argv[0]);
free(pi->progs->argv[0]);
pi->progs->argv[0] = *list++; pi->progs->argv[0] = *list++;
#ifndef __U_BOOT__ #ifndef __U_BOOT__
pi->progs->glob_result.gl_pathv[0] = pi->progs->glob_result.gl_pathv[0] =