colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stm32mp: cmd_stm32key: handle error in fuse_hash_value

Browse Source 
Handle errors in fuse_hash_value function.

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
This commit is contained in:
Patrick Delaunay
2021-06-28 14:55:59 +02:00
parent bc78d5f25a
commit fe24090eb7
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
arch/arm/mach-stm32mp/cmd_stm32key.c
View File

@@ -25,7 +25,7 @@ static void read_hash_value(u32 addr)
} }
} }
static void fuse_hash_value(u32 addr, bool print) static int fuse_hash_value(u32 addr, bool print)
{ {
struct udevice *dev; struct udevice *dev;
u32 word, val; u32 word, val;
@@ -36,21 +36,25 @@ static void fuse_hash_value(u32 addr, bool print)
&dev); &dev);
if (ret) { if (ret) {
log_err("Can't find stm32mp_bsec driver\n"); log_err("Can't find stm32mp_bsec driver\n");
return; return ret;
} }
for (i = 0; i < STM32_OTP_HASH_KEY_SIZE; i++) { for (i = 0; i < STM32_OTP_HASH_KEY_SIZE; i++) {
if (print)
printf("Fuse OTP %i : %x\n",
STM32_OTP_HASH_KEY_START + i,
__be32_to_cpu(*(u32 *)addr));
word = STM32_OTP_HASH_KEY_START + i; word = STM32_OTP_HASH_KEY_START + i;
val = __be32_to_cpu(*(u32 *)addr); val = __be32_to_cpu(*(u32 *)addr);
misc_write(dev, STM32_BSEC_OTP(word), &val, 4); if (print)
printf("Fuse OTP %i : %x\n", word, val);
ret = misc_write(dev, STM32_BSEC_OTP(word), &val, 4);
if (ret != 4) {
log_err("Fuse OTP %i failed\n", word);
return ret;
}
addr += 4; addr += 4;
} }
return 0;
} }
static int confirm_prog(void) static int confirm_prog(void)
@@ -104,7 +108,9 @@ static int do_stm32key_fuse(struct cmd_tbl *cmdtp, int flag, int argc, char *con
if (!yes && !confirm_prog()) if (!yes && !confirm_prog())
return CMD_RET_FAILURE; return CMD_RET_FAILURE;
fuse_hash_value(addr, !yes); if (fuse_hash_value(addr, !yes))
return CMD_RET_FAILURE;
printf("Hash key updated !\n"); printf("Hash key updated !\n");
return CMD_RET_SUCCESS; return CMD_RET_SUCCESS;