colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmd: improve coninfo output formatting

Browse Source 
Device name are typically longer than 8 characters. This leads to ragged
output.
Only the I and O bit of the device flags are of interest for the user.
Writing a hexadecimal number is just confusing.

Before the patch the output looked like this:

    => coninfo
    List of available devices:
    pl011@9000000 00000007 IO stdin stdout stderr
    serial   00000003 IO
    usbkbd   00000001 I.

With the patch the output looks like this:

    => coninfo
    List of available devices
    |-- pl011@9000000 (IO)
    |   |-- stdin
    |   |-- stdout
    |   |-- stderr
    |-- serial (IO)
    |-- usbkbd (I)

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Heinrich Schuchardt
2023-01-28 01:11:56 +01:00
parent eeb55254dd
commit fe34e163e0
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/console.c
View File

@@ -22,23 +22,21 @@ static int do_coninfo(struct cmd_tbl *cmd, int flag, int argc,
/* Scan for valid output and input devices */ /* Scan for valid output and input devices */
puts ("List of available devices:\n"); puts("List of available devices\n");
list_for_each(pos, list) { list_for_each(pos, list) {
dev = list_entry(pos, struct stdio_dev, list); dev = list_entry(pos, struct stdio_dev, list);
printf ("%-8s %08x %c%c ", printf("|-- %s (%s%s)\n",
dev->name, dev->name,
dev->flags, (dev->flags & DEV_FLAGS_INPUT) ? "I" : "",
(dev->flags & DEV_FLAGS_INPUT) ? 'I' : '.', (dev->flags & DEV_FLAGS_OUTPUT) ? "O" : "");
(dev->flags & DEV_FLAGS_OUTPUT) ? 'O' : '.');
for (l = 0; l < MAX_FILES; l++) { for (l = 0; l < MAX_FILES; l++) {
if (stdio_devices[l] == dev) { if (stdio_devices[l] == dev) {
printf ("%s ", stdio_names[l]); printf("| |-- %s\n", stdio_names[l]);
} }
} }
putc ('\n');
} }
return 0; return 0;
} }