colin/uosc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: use primary_click for chapter indicators (#932)

Browse Source 
Listening to `primary_down`, but not listening to the `primary_up` event
leads to that `up` event getting forwarded. Listening to `primary_click`
instead avoids that problem.

Seeking chapters now happens on button up instead of button down, but
that shouldn't be a problem for anyone and makes their behavior
consistent with other clickable UI elements.

ref. https://github.com/tomasklaen/uosc/discussions/931
This commit is contained in:
christoph-heinrich
2024-07-12 22:44:48 +02:00
committed by GitHub
parent c660db0743
commit 9fa7220da4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/uosc/elements/Timeline.lua
View File

@@ -317,7 +317,7 @@ function Timeline:render()
if chapter ~= hovered_chapter then draw_chapter(chapter.time, diamond_radius) end if chapter ~= hovered_chapter then draw_chapter(chapter.time, diamond_radius) end
local circle = {point = {x = t2x(chapter.time), y = fay - 1}, r = diamond_radius_hovered} local circle = {point = {x = t2x(chapter.time), y = fay - 1}, r = diamond_radius_hovered}
if visibility > 0 then if visibility > 0 then
cursor:zone('primary_down', circle, function() cursor:zone('primary_click', circle, function()
mp.commandv('seek', chapter.time, 'absolute+exact') mp.commandv('seek', chapter.time, 'absolute+exact')
end) end)
end end