colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

m-lua-scripting: downgrade notice to debug when printing operation errors

Browse Source 
These errors are propagated to the caller, so it's the caller's
responsibility to print them appropriately, if necessary. Printing
a notice also here is only confusing.

A debug mesage is still be useful for developers to understand the flow.
This commit is contained in:
George Kiagiadakis
2024-03-25 09:55:59 +02:00
parent c89316e52c
commit 053d2ae69c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/module-lua-scripting/api/api.c
View File

@@ -468,7 +468,7 @@ object_activate_done (WpObject *o, GAsyncResult * res, GClosure * closure)
int n_vals = 1; int n_vals = 1;
if (!wp_object_activate_finish (o, res, &error)) { if (!wp_object_activate_finish (o, res, &error)) {
wp_notice_object (o, "%s", error->message); wp_debug_object (o, "%s", error->message);
if (closure) { if (closure) {
g_value_init (&val[1], G_TYPE_STRING); g_value_init (&val[1], G_TYPE_STRING);
g_value_set_string (&val[1], error->message); g_value_set_string (&val[1], error->message);
@@ -1463,7 +1463,7 @@ si_adapter_set_ports_format_done (WpObject *o, GAsyncResult * res,
int n_vals = 1; int n_vals = 1;
if (!wp_si_adapter_set_ports_format_finish (WP_SI_ADAPTER (o), res, &error)) { if (!wp_si_adapter_set_ports_format_finish (WP_SI_ADAPTER (o), res, &error)) {
wp_notice_object (o, "%s", error->message); wp_debug_object (o, "%s", error->message);
if (closure) { if (closure) {
g_value_init (&val[1], G_TYPE_STRING); g_value_init (&val[1], G_TYPE_STRING);
g_value_set_string (&val[1], error->message); g_value_set_string (&val[1], error->message);