colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

m-lua-scripting: make sure pod is successfully parsed

Browse Source 
Otherwise show a warning
This commit is contained in:
Julian Bouzas
2021-06-24 10:34:51 -04:00
parent 671b8110d9
commit 412fae485a
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
modules/module-lua-scripting/pod.c
View File

@@ -921,7 +921,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
/* Boolean */
else if (wp_spa_pod_is_boolean (pod)) {
gboolean value = FALSE;
wp_spa_pod_get_boolean (pod, &value);
g_warn_if_fail (wp_spa_pod_get_boolean (pod, &value));
lua_pushboolean (L, value);
}
@@ -930,7 +930,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
guint32 value = 0;
WpSpaIdTable idtable = NULL;
WpSpaIdValue idval = NULL;
wp_spa_pod_get_id (pod, &value);
g_warn_if_fail (wp_spa_pod_get_id (pod, &value));
if (field_idval && SPA_TYPE_Id ==
wp_spa_id_value_get_value_type (field_idval, &idtable)) {
idval = wp_spa_id_table_find_value (idtable, value);
@@ -944,7 +944,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
/* Int */
else if (wp_spa_pod_is_int (pod)) {
gint value = 0;
wp_spa_pod_get_int (pod, &value);
g_warn_if_fail (wp_spa_pod_get_int (pod, &value));
lua_pushinteger (L, value);
}
@@ -958,21 +958,21 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
/* Float */
else if (wp_spa_pod_is_float (pod)) {
float value = 0;
wp_spa_pod_get_float (pod, &value);
g_warn_if_fail (wp_spa_pod_get_float (pod, &value));
lua_pushnumber (L, value);
}
/* Double */
else if (wp_spa_pod_is_double (pod)) {
double value = 0;
wp_spa_pod_get_double (pod, &value);
g_warn_if_fail (wp_spa_pod_get_double (pod, &value));
lua_pushnumber (L, value);
}
/* String */
else if (wp_spa_pod_is_string (pod)) {
const gchar *value = NULL;
wp_spa_pod_get_string (pod, &value);
g_warn_if_fail (wp_spa_pod_get_string (pod, &value));
lua_pushstring (L, value);
}
@@ -980,7 +980,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
else if (wp_spa_pod_is_bytes (pod)) {
gconstpointer value = NULL;
guint32 size = 0;
wp_spa_pod_get_bytes (pod, &value, &size);
g_warn_if_fail (wp_spa_pod_get_bytes (pod, &value, &size));
char str[size + 1];
for (guint i = 0; i < size; i++)
str[i] = ((const gchar *)value)[i];
@@ -991,7 +991,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
/* Pointer */
else if (wp_spa_pod_is_pointer (pod)) {
gconstpointer value = NULL;
wp_spa_pod_get_pointer (pod, &value);
g_warn_if_fail (wp_spa_pod_get_pointer (pod, &value));
if (!value)
lua_pushnil (L);
else
@@ -1001,14 +1001,14 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
/* Fd */
else if (wp_spa_pod_is_fd (pod)) {
gint64 value = 0;
wp_spa_pod_get_fd (pod, &value);
g_warn_if_fail (wp_spa_pod_get_fd (pod, &value));
lua_pushinteger (L, value);
}
/* Rectangle */
else if (wp_spa_pod_is_rectangle (pod)) {
guint32 width = 0, height = 0;
wp_spa_pod_get_rectangle (pod, &width, &height);
g_warn_if_fail (wp_spa_pod_get_rectangle (pod, &width, &height));
lua_newtable (L);
lua_pushstring (L, "Rectangle");
lua_setfield (L, -2, "pod_type");
@@ -1021,7 +1021,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
/* Fraction */
else if (wp_spa_pod_is_fraction (pod)) {
guint32 num = 0, denom = 0;
wp_spa_pod_get_fraction (pod, &num, &denom);
g_warn_if_fail (wp_spa_pod_get_fraction (pod, &num, &denom));
lua_newtable (L);
lua_pushstring (L, "Fraction");
lua_setfield (L, -2, "pod_type");
@@ -1038,7 +1038,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
const gchar *id_name = NULL;
g_auto (GValue) item = G_VALUE_INIT;
g_autoptr (WpIterator) it = NULL;
wp_spa_pod_get_object (pod, &id_name, NULL);
g_warn_if_fail (wp_spa_pod_get_object (pod, &id_name, NULL));
lua_newtable (L);
lua_pushstring (L, "Object");
lua_setfield (L, -2, "pod_type");
@@ -1052,7 +1052,7 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
g_autoptr (WpSpaPod) val = NULL;
//FIXME: this is suboptimal because _get_property() converts
// the key to a short name and we convert it back
wp_spa_pod_get_property (prop, &key, &val);
g_warn_if_fail (wp_spa_pod_get_property (prop, &key, &val));
if (key) {
push_luapod (L, val,
wp_spa_id_table_find_value_from_short_name (values_table, key));
@@ -1090,7 +1090,8 @@ push_luapod (lua_State *L, WpSpaPod *pod, WpSpaIdValue field_idval)
guint32 offset = 0;
const char *type_name = NULL;
g_autoptr (WpSpaPod) val = NULL;
wp_spa_pod_get_control (control, &offset, &type_name, &val);
g_warn_if_fail (wp_spa_pod_get_control (control, &offset, &type_name,
&val));
lua_newtable (L);
lua_pushinteger (L, offset);
lua_setfield (L, -2, "offset");