colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

log: rename "message" level to "notice" and print criticals with "E"

Browse Source 
Syslog calls this level "notice" and I prefer it because we use it
to display significant messages that are not warnings, but they
are not really "standard", as GLib wants them to be. There is nothing
"standard" about log messages in general.

Also, make these notice messages be enabled at debug level 2, together
with warnings. The default log.level is 2 and it is a good idea to show
notices by default too.

Finally, show them in the log with "N" and also change criticals to be
shown with "E", meaning "error"... Then promote G_LOG_LEVEL_ERROR
messages to be shown with "F", meaning "fatal", because in fact these
messages are always fatal and always call abort(). Still, keep the term
"critical" in the functions to make sure that whoever uses them is aware
that this level is only for critical conditions and not suitable to
display any kind of error.
This commit is contained in:
George Kiagiadakis
2023-05-18 16:19:49 +03:00
parent 89c31d8190
commit 4f27d18bd3
18 changed files with 45 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/module-lua-scripting/api/api.c
View File

@@ -357,7 +357,7 @@ static int
log_warning (lua_State *L) { return log_log (L, G_LOG_LEVEL_WARNING); }
static int
log_message (lua_State *L) { return log_log (L, G_LOG_LEVEL_MESSAGE); }
log_notice (lua_State *L) { return log_log (L, G_LOG_LEVEL_MESSAGE); }
static int
log_info (lua_State *L) { return log_log (L, G_LOG_LEVEL_INFO); }
@@ -370,7 +370,7 @@ log_trace (lua_State *L) { return log_log (L, WP_LOG_LEVEL_TRACE); }
static const luaL_Reg log_obj_funcs[] = {
{ "warning", log_warning },
{ "message", log_message },
{ "notice", log_notice },
{ "info", log_info },
{ "debug", log_debug },
{ "trace", log_trace },
@@ -399,7 +399,7 @@ log_open_topic (lua_State *L)
static const luaL_Reg log_funcs[] = {
{ "open_topic", log_open_topic },
{ "warning", log_warning },
{ "message", log_message },
{ "notice", log_notice },
{ "info", log_info },
{ "debug", log_debug },
{ "trace", log_trace },
@@ -435,7 +435,7 @@ object_activate_done (WpObject *o, GAsyncResult * res, GClosure * closure)
int n_vals = 1;
if (!wp_object_activate_finish (o, res, &error)) {
wp_message_object (o, "%s", error->message);
wp_notice_object (o, "%s", error->message);
if (closure) {
g_value_init (&val[1], G_TYPE_STRING);
g_value_set_string (&val[1], error->message);
@@ -1386,7 +1386,7 @@ si_adapter_set_ports_format_done (WpObject *o, GAsyncResult * res,
int n_vals = 1;
if (!wp_si_adapter_set_ports_format_finish (WP_SI_ADAPTER (o), res, &error)) {
wp_message_object (o, "%s", error->message);
wp_notice_object (o, "%s", error->message);
if (closure) {
g_value_init (&val[1], G_TYPE_STRING);
g_value_set_string (&val[1], error->message);