colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

simple-policy: match the requested role to a stream in find_endpoint

Browse Source 
... and simplify some code there
This commit is contained in:
George Kiagiadakis
2019-07-05 18:35:25 +03:00
committed by Julian Bouzas
parent 2a397faa30
commit 700f55670a
1 changed files with 27 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
modules/module-simple-policy.c
View File

@@ -316,44 +316,45 @@ simple_policy_find_endpoint (WpPolicy *policy, GVariant *props,
if (!ptr_array) if (!ptr_array)
return NULL; return NULL;
/* TODO: for now we statically return the first stream
* we should be looking into the media.role eventually */
g_variant_lookup (props, "media.role", "&s", &role);
if (!g_strcmp0 (action, "mixer") && !g_strcmp0 (role, "Master"))
*stream_id = WP_STREAM_ID_NONE;
else
*stream_id = 0;
/* Find and return the "selected" endpoint */ /* Find and return the "selected" endpoint */
/* FIXME: fix the endpoint API, this is terrible */
for (i = 0; i < ptr_array->len; i++) { for (i = 0; i < ptr_array->len; i++) {
ep = g_ptr_array_index (ptr_array, i); ep = g_ptr_array_index (ptr_array, i);
GVariantIter iter;
g_autoptr (GVariant) controls = NULL;
g_autoptr (GVariant) value = NULL; g_autoptr (GVariant) value = NULL;
const gchar *name;
guint id; guint id;
controls = wp_endpoint_list_controls (ep); id = wp_endpoint_find_control (ep, WP_STREAM_ID_NONE, "selected");
g_variant_iter_init (&iter, controls); if (id == WP_CONTROL_ID_NONE)
while ((value = g_variant_iter_next_value (&iter))) { continue;
if (!g_variant_lookup (value, "name", "&s", &name)
|| !g_str_equal (name, "selected")) {
g_variant_unref (value);
continue;
}
g_variant_lookup (value, "id", "u", &id);
g_variant_unref (value);
}
value = wp_endpoint_get_control_value (ep, id); value = wp_endpoint_get_control_value (ep, id);
if (value && g_variant_get_boolean (value)) if (value && g_variant_get_boolean (value)) {
return g_object_ref (ep); g_object_ref (ep);
goto select_stream;
}
} }
/* If not found, return the first endpoint */ /* If not found, return the first endpoint */
return (ptr_array->len > 1) ? ep = (ptr_array->len > 1) ?
g_object_ref (g_ptr_array_index (ptr_array, 0)) : NULL; g_object_ref (g_ptr_array_index (ptr_array, 0)) : NULL;
select_stream:
g_variant_lookup (props, "media.role", "&s", &role);
if (!g_strcmp0 (action, "mixer") && !g_strcmp0 (role, "Master"))
*stream_id = WP_STREAM_ID_NONE;
else if (ep) {
/* the default role is "Multimedia" */
if (!role)
role = "Multimedia";
*stream_id = wp_endpoint_find_stream (ep, role);
/* role not found, try the first stream */
if (*stream_id == WP_STREAM_ID_NONE) {
g_warning ("role '%s' not found in endpoint", role);
*stream_id = 0;
}
}
return ep;
} }
static void static void