colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "api: module: support loading arguments from file"

Browse Source 
This reverts commit 2ae1b3cbd9.

This is not a good API. It was only allowed temporarily in 0.4.15
to get things done. We should approach this properly in 0.5
This commit is contained in:
George Kiagiadakis
2023-10-24 11:55:52 +03:00
parent 22cb31571d
commit dbf8204cf9
4 changed files with 3 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
modules/module-lua-scripting/api/api.c
View File

@@ -6,7 +6,6 @@
* SPDX-License-Identifier: MIT
*/
#include "lua.h"
#include <glib/gstdio.h>
#include <wp/wp.h>
#include <pipewire/pipewire.h>
@@ -1537,20 +1536,8 @@ impl_module_new (lua_State *L)
properties = wplua_table_to_properties (L, 3);
}
bool load_file = false; // Load args as file path
if (lua_type (L, 4) != LUA_TNONE && lua_type (L, 4) != LUA_TNIL) {
luaL_checktype (L, 4, LUA_TBOOLEAN);
load_file = lua_toboolean(L, 4);
}
WpImplModule *m = NULL;
if (load_file) {
m = wp_impl_module_load_file (get_wp_export_core (L),
name, args, properties);
} else {
m = wp_impl_module_load (get_wp_export_core (L),
name, args, properties);
}
WpImplModule *m = wp_impl_module_load (get_wp_export_core (L),
name, args, properties);
if (m) {
wplua_pushobject (L, m);