Files
wireplumber/lib/wp/transition.c
Barnabás Pőcze 89b6766cd6 transition: ensure single completion and finish
At the moment, the same transition can be completed multiple times
(assuming sufficiently high reference count):

  return_error()
  finish()
  return_error()

The consequence of that is that the transition closure will be
invoked multiple times. This is unexpected.

Add some guards against completing a transition or calling finish()
multiple times.

Fixes #628
2024-05-18 01:36:39 +02:00

567 lines
18 KiB
C
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* WirePlumber
*
* Copyright © 2020 Collabora Ltd.
* @author George Kiagiadakis <george.kiagiadakis@collabora.com>
*
* SPDX-License-Identifier: MIT
*/
#include "transition.h"
#include "log.h"
#include "error.h"
WP_DEFINE_LOCAL_LOG_TOPIC ("wp-transition")
/*! \defgroup wptransition Transitions */
/*!
* \struct WpTransition
*
* A transition is an asynchronous operation, like GTask, that contains an
* internal state machine, where a series of 'steps' are executed in order to
* complete the operation.
*
* For every step, _WpTransitionClass::get_next_step()
* is called in order to determine the next step to execute. Afterwards,
* _WpTransitionClass::execute_step() is called
* to perform any actions necessary to complete this step. When execution
* of the step is done, the operation's code must call wp_transition_advance()
* in order to continue to the next step. If an error occurs, the operation's
* code must call wp_transition_return_error() instead, in which case the
* transition completes immediately and wp_transition_had_error() returns TRUE.
*
* Typically, every step will start an asynchronous operation. Although it is
* possible, the WpTransition base class does not expect
* _WpTransitionClass::execute_step() to call wp_transition_advance() directly.
* Instead, it is expected that wp_transition_advance() will be called from
* the callback that the step's asynchronous operation will call when it is
* completed.
*
* \gproperties
* \gproperty{completed, gboolean, G_PARAM_READABLE,
* Whether the transition has completed\, meaning its callback (if set)
* has been invoked. This can only happen after the final step has been
* reached or wp_transition_return_error() has been called.
* \n
* This property is guaranteed to change from FALSE to TRUE exactly once.
* \n
* The GObject \c notify signal for this change is emitted in the same context
* as the transitions callback\, immediately after that callback is invoked.}
*/
typedef struct _WpTransitionPrivate WpTransitionPrivate;
struct _WpTransitionPrivate
{
/* source obj & callback */
GObject *source_object;
GCancellable *cancellable;
GClosure *closure;
/* GAsyncResult tag */
gpointer tag;
/* task data */
gpointer data;
GDestroyNotify data_destroy;
/* state machine */
gboolean started;
gboolean completed;
gboolean finished;
guint step;
GError *error;
};
enum {
PROP_0,
PROP_COMPLETED,
};
static void wp_transition_async_result_init (GAsyncResultIface *iface);
G_DEFINE_ABSTRACT_TYPE_WITH_CODE (WpTransition, wp_transition, G_TYPE_OBJECT,
G_IMPLEMENT_INTERFACE (G_TYPE_ASYNC_RESULT, wp_transition_async_result_init)
G_ADD_PRIVATE (WpTransition))
static void
wp_transition_init (WpTransition * self)
{
}
static void
wp_transition_finalize (GObject * object)
{
WpTransition * self = WP_TRANSITION (object);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
if (priv->data && priv->data_destroy)
priv->data_destroy (priv->data);
g_clear_error (&priv->error);
g_clear_pointer (&priv->closure, g_closure_unref);
g_clear_object (&priv->cancellable);
g_clear_object (&priv->source_object);
G_OBJECT_CLASS (wp_transition_parent_class)->finalize (object);
}
static void
wp_transition_get_property (GObject * object, guint property_id,
GValue * value, GParamSpec * pspec)
{
WpTransition * self = WP_TRANSITION (object);
switch (property_id) {
case PROP_COMPLETED:
g_value_set_boolean (value, wp_transition_get_completed (self));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
}
static void
wp_transition_class_init (WpTransitionClass * klass)
{
GObjectClass *object_class = (GObjectClass *) klass;
object_class->finalize = wp_transition_finalize;
object_class->get_property = wp_transition_get_property;
g_object_class_install_property (object_class, PROP_COMPLETED,
g_param_spec_boolean ("completed", "completed",
"Whether the transition has completed", FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
}
static GObject *
get_source_object (GAsyncResult * res)
{
WpTransitionPrivate *priv =
wp_transition_get_instance_private (WP_TRANSITION (res));
return priv->source_object ? g_object_ref (priv->source_object) : NULL;
}
static void
wp_transition_async_result_init (GAsyncResultIface * iface)
{
iface->get_source_object = get_source_object;
iface->get_user_data =
(gpointer (*)(GAsyncResult *)) wp_transition_get_data;
iface->is_tagged =
(gboolean (*)(GAsyncResult *, gpointer)) wp_transition_is_tagged;
}
/*!
* \brief Creates a WpTransition acting on \a source_object.
*
* When the transition is done, \a callback will be invoked.
*
* The transition does not automatically start executing steps. You must
* call wp_transition_advance() after creating it in order to start it.
*
* \note The transition is automatically unref'ed after the \a callback
* has been executed. If you wish to keep an additional reference on it,
* you need to ref it explicitly.
*
* \ingroup wptransition
* \param type the GType of the WpTransition subclass to instantiate
* \param source_object (nullable) (type GObject): the GObject that owns this
* task, or NULL
* \param cancellable (nullable): optional GCancellable
* \param callback (scope async): a GAsyncReadyCallback
* \param callback_data (closure): user data passed to \a callback
* \returns (transfer none): the new transition
*/
WpTransition *
wp_transition_new (GType type,
gpointer source_object, GCancellable * cancellable,
GAsyncReadyCallback callback, gpointer callback_data)
{
return wp_transition_new_closure (type, source_object, cancellable,
g_cclosure_new (G_CALLBACK (callback), callback_data, NULL));
}
/*!
* \brief Creates a WpTransition acting on \a source_object.
* When the transition is done, \a closure will be invoked.
*
* The transition does not automatically start executing steps. You must
* call wp_transition_advance() after creating it in order to start it.
*
* Note that the transition is automatically unref'ed after the \a closure
* has been executed. If you wish to keep an additional reference on it,
* you need to ref it explicitly.
*
* \ingroup wptransition
* \param type the GType of the WpTransition subclass to instantiate
* \param source_object (nullable) (type GObject): the GObject that owns this
* task, or NULL
* \param cancellable (nullable): optional GCancellable
* \param closure (nullable): a GAsyncReadyCallback wrapped in a GClosure
* \returns (transfer none): the new transition
*/
WpTransition *
wp_transition_new_closure (GType type, gpointer source_object,
GCancellable * cancellable, GClosure * closure)
{
g_return_val_if_fail (g_type_is_a (type, WP_TYPE_TRANSITION), NULL);
g_return_val_if_fail (G_IS_OBJECT (source_object), NULL);
WpTransition *self = g_object_new (type, NULL);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
priv->source_object = source_object ? g_object_ref (source_object) : NULL;
priv->cancellable = cancellable ? g_object_ref (cancellable) : NULL;
if (closure) {
priv->closure = g_closure_ref (closure);
g_closure_sink (closure);
if (G_CLOSURE_NEEDS_MARSHAL (closure))
g_closure_set_marshal (closure, g_cclosure_marshal_VOID__OBJECT);
}
return self;
}
/*!
* \brief Gets the source object from the transition.
*
* Like g_async_result_get_source_object(), but does not ref the object.
*
* \ingroup wptransition
* \param self the transition
* \returns (transfer none) (type GObject): the source object
*/
gpointer
wp_transition_get_source_object (WpTransition * self)
{
g_return_val_if_fail (WP_IS_TRANSITION (self), NULL);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
return priv->source_object;
}
/*!
* \brief Checks if \a self has the given \a tag (generally a function pointer
* indicating the function \a self was created by).
*
* \ingroup wptransition
* \param self the transition
* \param tag a tag
* \returns TRUE if \a self has the indicated \a tag , FALSE if not.
*/
gboolean
wp_transition_is_tagged (WpTransition * self, gpointer tag)
{
g_return_val_if_fail (WP_IS_TRANSITION (self), FALSE);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
return (priv->tag == tag);
}
/*!
* \brief Gets \a self 's source tag.
* \see wp_transition_set_source_tag().
* \ingroup wptransition
* \param self the transition
* \returns (transfer none): the transition's source tag
*/
gpointer
wp_transition_get_source_tag (WpTransition * self)
{
g_return_val_if_fail (WP_IS_TRANSITION (self), NULL);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
return priv->tag;
}
/*!
* \brief Sets \a self 's source tag.
*
* You can use this to tag a transition's return
* value with a particular pointer (usually a pointer to the function doing
* the tagging) and then later check it using wp_transition_get_source_tag()
* (or g_async_result_is_tagged()) in the transition's "finish" function,
* to figure out if the response came from a particular place.
* \ingroup wptransition
* \param self the transition
* \param tag an opaque pointer indicating the source of this transition
*/
void
wp_transition_set_source_tag (WpTransition * self, gpointer tag)
{
g_return_if_fail (WP_IS_TRANSITION (self));
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
priv->tag = tag;
}
/*!
* \brief Gets \a self 's data.
* \see wp_transition_set_data().
* \ingroup wptransition
* \param self the transition
* \returns (transfer none): the transition's data
*/
gpointer
wp_transition_get_data (WpTransition * self)
{
g_return_val_if_fail (WP_IS_TRANSITION (self), NULL);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
return priv->data;
}
/*!
* \brief Sets \a self 's data (freeing the existing data, if any). This can be an
* arbitrary user structure that holds data associated with this transition.
*
* \ingroup wptransition
* \param self the transition
* \param data (nullable): transition-specific user data
* \param data_destroy (nullable): GDestroyNotify for \a data
*/
void
wp_transition_set_data (WpTransition * self, gpointer data,
GDestroyNotify data_destroy)
{
g_return_if_fail (WP_IS_TRANSITION (self));
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
if (priv->data && priv->data_destroy)
priv->data_destroy (priv->data);
priv->data = data;
priv->data_destroy = data_destroy;
}
/*!
* \brief Checks if the transition completed.
* \ingroup wptransition
* \param self the transition
* \returns TRUE if the transition has completed (with or without an error),
* FALSE otherwise
*/
gboolean
wp_transition_get_completed (WpTransition * self)
{
g_return_val_if_fail (WP_IS_TRANSITION (self), FALSE);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
return priv->completed;
}
/*!
* \brief Checks if the transition completed with an error.
* \ingroup wptransition
* \param self the transition
* \returns TRUE if the transition completed with an error, FALSE otherwise
*/
gboolean
wp_transition_had_error (WpTransition * self)
{
g_return_val_if_fail (WP_IS_TRANSITION (self), FALSE);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
return priv->step == WP_TRANSITION_STEP_ERROR;
}
static void
wp_transition_return (WpTransition * self, WpTransitionPrivate *priv)
{
g_assert (priv->completed);
if (priv->closure) {
GValue values[2] = { G_VALUE_INIT, G_VALUE_INIT };
g_value_init (&values[0], G_TYPE_OBJECT);
g_value_init (&values[1], G_TYPE_OBJECT);
g_value_set_object (&values[0], priv->source_object);
g_value_set_object (&values[1], self);
g_closure_invoke (priv->closure, NULL, 2, values, NULL);
g_value_unset (&values[0]);
g_value_unset (&values[1]);
}
g_object_notify (G_OBJECT (self), "completed");
/* WARNING */
g_object_unref (self);
}
/*!
* \brief Advances the transition to the next step.
*
* This initially calls _WpTransitionClass::get_next_step()
* in order to determine what the next step is.
* If _WpTransitionClass::get_next_step() returns a step
* different than the previous one, it calls
* _WpTransitionClass::execute_step() to execute it.
*
* The very first time that _WpTransitionClass::get_next_step()
* is called, its \a step parameter equals WP_TRANSITION_STEP_NONE.
*
* When _WpTransitionClass::get_next_step() returns
* WP_TRANSITION_STEP_NONE this function completes the transition,
* calling the transition's callback and then unref-ing the transition.
*
* When _WpTransitionClass::get_next_step() returns
* WP_TRANSITION_STEP_ERROR, this function calls wp_transition_return_error(),
* unless it has already been called directly by
* _WpTransitionClass::get_next_step().
*
* In error conditions, _WpTransitionClass::execute_step()
* is called once with \a step being WP_TRANSITION_STEP_ERROR, allowing the
* implementation to rollback any changes or cancel underlying jobs, if necessary.
*
* \ingroup wptransition
* \param self the transition
*/
void
wp_transition_advance (WpTransition * self)
{
g_return_if_fail (WP_IS_TRANSITION (self));
/* keep a reference to avoid issues when wp_transition_return_error() is
called from within get_next_step() */
g_autoptr (WpTransition) self_ref = g_object_ref (self);
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
guint next_step;
GError *error = NULL;
if (priv->completed) {
wp_warning_object (priv->source_object, "tried to advance completed transition");
return;
}
priv->started = TRUE;
if (g_cancellable_set_error_if_cancelled (priv->cancellable, &error)) {
wp_transition_return_error (self, error);
return;
}
/* find the next step */
next_step = WP_TRANSITION_GET_CLASS (self)->get_next_step (self, priv->step);
wp_trace_object (priv->source_object, "transition: %d -> %d", priv->step,
next_step);
if (next_step == WP_TRANSITION_STEP_ERROR) {
/* return error if the callback didn't do it already */
if (G_UNLIKELY (!priv->completed)) {
wp_transition_return_error (self, g_error_new (WP_DOMAIN_LIBRARY,
WP_LIBRARY_ERROR_INVARIANT, "state machine error"));
}
return;
}
g_assert (!priv->completed);
/* if we reached STEP_NONE again, that means we reached the next state */
if (next_step == WP_TRANSITION_STEP_NONE) {
/* complete the transition */
priv->step = next_step;
priv->completed = TRUE;
wp_transition_return (self, priv);
return;
}
/* still at the same step, this means we are waiting for something */
if (next_step == priv->step)
return;
wp_trace_object (priv->source_object, "transition: execute %d", next_step);
/* execute the next step */
priv->step = next_step;
WP_TRANSITION_GET_CLASS (self)->execute_step (self, priv->step);
}
/*!
* \brief Completes the transition with an error.
*
* This can be called anytime from within any virtual function or an async
* job handler.
*
* \note In most cases this will also unref the transition, so it is
* not safe to access it after this function has been called.
*
* \ingroup wptransition
* \param self the transition
* \param error (transfer full): a GError
*/
void
wp_transition_return_error (WpTransition * self, GError * error)
{
g_return_if_fail (WP_IS_TRANSITION (self));
WpTransitionPrivate *priv = wp_transition_get_instance_private (self);
/* don't allow _return_error() to be called multiple times,
as it is dangerous to recurse in execute_step() */
if (G_UNLIKELY (priv->completed)) {
wp_warning_object (priv->source_object,
"tried to set error on completed transition: %s", error->message);
g_error_free (error);
return;
}
priv->step = WP_TRANSITION_STEP_ERROR;
priv->error = error;
priv->completed = TRUE;
/* allow the implementation to rollback changes */
if (WP_TRANSITION_GET_CLASS (self)->execute_step)
WP_TRANSITION_GET_CLASS (self)->execute_step (self, priv->step);
wp_transition_return (self, priv);
}
/*!
* \brief Returns the final return status of the transition and its error,
* if there was one.
*
* This is meant to be called from within the GAsyncReadyCallback
* that was specified in wp_transition_new().
*
* \ingroup wptransition
* \param res a transition, as a GAsyncResult
* \param error (out) (optional): a location to return the transition's error,
* if any
* \returns TRUE if the transition completed successfully, FALSE if there
* was an error
*/
gboolean
wp_transition_finish (GAsyncResult * res, GError ** error)
{
g_return_val_if_fail (WP_IS_TRANSITION (res), FALSE);
WpTransitionPrivate *priv =
wp_transition_get_instance_private (WP_TRANSITION (res));
if (priv->error) {
g_propagate_error (error, priv->error);
priv->error = NULL;
} else if (!priv->started) {
priv->step = WP_TRANSITION_STEP_ERROR;
g_propagate_error (error, g_error_new (WP_DOMAIN_LIBRARY,
WP_LIBRARY_ERROR_INVARIANT, "finished before starting"));
} else if (!priv->completed) {
priv->step = WP_TRANSITION_STEP_ERROR;
g_propagate_error (error, g_error_new (WP_DOMAIN_LIBRARY,
WP_LIBRARY_ERROR_INVARIANT, "finished before completion"));
} else if (priv->finished) {
priv->step = WP_TRANSITION_STEP_ERROR;
g_propagate_error (error, g_error_new (WP_DOMAIN_LIBRARY,
WP_LIBRARY_ERROR_INVARIANT, "finished multiple times"));
}
priv->finished = TRUE;
wp_trace_object (priv->source_object, "transition: finished %s",
(priv->step == WP_TRANSITION_STEP_NONE) ? "ok" : "with error");
return (priv->step == WP_TRANSITION_STEP_NONE);
}