nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

do NEVER unset $table or $db;

Browse Source 
no need to test for isset() on $db and $table;
always test with strlen() for valid $table or $db;
This commit is contained in:
Sebastian Mendel
2007-03-30 09:12:05 +00:00
parent 711eb76ce3
commit 008734f8b0
23 changed files with 82 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/db_table_exists.lib.php
View File

@@ -11,7 +11,7 @@
*
*/
if (empty($is_db)) {
if (isset($db) && strlen($db)) {
if (strlen($db)) {
$is_db = @PMA_DBI_select_db($db);
} else {
$is_db = false;
@@ -40,7 +40,7 @@ if (empty($is_db)) {
if (empty($is_table) && !defined('PMA_SUBMIT_MULT')) {
// Not a valid table name -> back to the db_sql.php
if (isset($table) && strlen($table)) {
if (strlen($table)) {
$_result = PMA_DBI_try_query(
'SHOW TABLES LIKE \'' . PMA_sqlAddslashes($table, true) . '\';',
null, PMA_DBI_QUERY_STORE);
@@ -52,7 +52,7 @@ if (empty($is_table) && !defined('PMA_SUBMIT_MULT')) {
if (! $is_table) {
if (! defined('IS_TRANSFORMATION_WRAPPER')) {
if (isset($table) && strlen($table)) {
if (strlen($table)) {
// SHOW TABLES doesn't show temporary tables, so try select
// (as it can happen just in case temporary table, it should be
// fast):