do NEVER unset $table or $db;

no need to test for isset() on $db and $table;
always test with strlen() for valid $table or $db;
This commit is contained in:
Sebastian Mendel
2007-03-30 09:12:05 +00:00
parent 711eb76ce3
commit 008734f8b0
23 changed files with 82 additions and 91 deletions

View File

@@ -38,7 +38,7 @@ $cfgRelation = PMA_getRelationsParam();
/**
* Defines the url to return to in case of error in a sql statement
*/
if (isset($table)) {
if (strlen($table)) {
$err_url = 'tbl_sql.php?' . PMA_generate_common_url($db, $table);
} else {
$err_url = 'db_sql.php?' . PMA_generate_common_url($db);
@@ -57,7 +57,7 @@ PMA_DBI_select_db($db);
*/
if (isset($selected_tbl) && is_array($selected_tbl)) {
$the_tables = $selected_tbl;
} elseif (isset($table)) {
} elseif (strlen($table)) {
$the_tables[] = $table;
}
$multi_tables = (count($the_tables) > 1);