bug #2910000 [gui] ShowServerInfo should hide all server info from main page

ChangeLog

@@ -10,6 +10,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
   thanks to Virsacer - virsacer
 - bug [history] QueryHistoryDB is not respected
 - bug #2905629 [auth] Blowfish secret is not hashed 
+- bug #2910000 [gui] ShowServerInfo should hide all server info from main page 
 
 3.2.4.0 (2009-12-02)
 - bug [engines] Innodb_buffer_pool_pages_latched no longer returned in status 

libraries/config.default.php

@@ -756,7 +756,7 @@ $cfg['ShowStats'] = true;
 $cfg['ShowPhpInfo'] = false;
 
 /**
- * show MySQL server information
+ * show MySQL server and web server information
  *
  * @global boolean $cfg['ShowServerInfo']
  */

main.php

@@ -182,19 +182,16 @@ echo '</div>';
 echo '</div>';
 echo '<div id="main_pane_right">';
 
-
-if ($server > 0) {
+if ($server > 0 && $GLOBALS['cfg']['ShowServerInfo']) {
     echo '<div class="group">';
     echo '<h2>MySQL</h2>';
     echo '<ul>' . "\n";
     PMA_printListItem($strServer . ': ' . $server_info, 'li_server_info');
     PMA_printListItem($strServerVersion . ': ' . PMA_MYSQL_STR_VERSION, 'li_server_version');
-    if ($GLOBALS['cfg']['ShowServerInfo']) {
     PMA_printListItem($strProtocolVersion . ': ' . PMA_DBI_get_proto_info(),
         'li_mysql_proto');
     PMA_printListItem($strUser . ': ' . htmlspecialchars($mysql_cur_user_and_host),
         'li_user_info');
-    }
 
     echo '    <li id="li_select_mysql_charset">';
     echo '        ' . $strMySQLCharset . ': '
@@ -207,10 +204,11 @@ if ($server > 0) {
     echo ' </div>';
 }
 
-
+if ($GLOBALS['cfg']['ShowServerInfo'] || $GLOBALS['cfg']['ShowPhpInfo']) {
     echo '<div class="group">';
     echo '<h2>' . $strWebServer . '</h2>';
     echo '<ul>';
+    if ($GLOBALS['cfg']['ShowServerInfo']) {
         PMA_printListItem($_SERVER['SERVER_SOFTWARE'], 'li_web_server_software');
 
         if ($server > 0) {
@@ -219,12 +217,14 @@ if ($server > 0) {
             PMA_printListItem($strPHPExtension . ': ' . $GLOBALS['cfg']['Server']['extension'],
                 'li_used_php_extension');
         }
+    }
 
     if ($cfg['ShowPhpInfo']) {
         PMA_printListItem($strShowPHPInfo, 'li_phpinfo', './phpinfo.php?' . $common_url_query);
     }
     echo '  </ul>';
     echo ' </div>';
+}
 
 echo '<div class="group">';
 echo '<h2>phpMyAdmin</h2>';