From 0858e97184064b0947660786e18159646c759334 Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Fri, 25 Jan 2008 17:42:23 +0000 Subject: [PATCH] patch #1873188 [GUI] Making db pager work when js is disabled --- ChangeLog | 2 ++ libraries/common.lib.php | 27 ++++++++++++++------------- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2ac9b247a..45152e579 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,8 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA - bug #1871038 [import] Notice: undefined variable first_sql_delimiter - bug #1873110 [export] Problem exporting with a LIMIT clause - bug #1871164 [GUI] Empty and navigation frame synch. +- patch #1873188 [GUI] Making db pager work when js is disabled, + thanks to Jürgen Wind - windkiel 2.11.4.0 (2008-01-12) - bug #1843428 [GUI] Space issue with DROP/DELETE/ALTER TABLE diff --git a/libraries/common.lib.php b/libraries/common.lib.php index 6c72d98ec..e2363b333 100644 --- a/libraries/common.lib.php +++ b/libraries/common.lib.php @@ -2074,8 +2074,8 @@ function PMA_pageselector($url, $rows, $pageNow = 1, $nbTotalPage = 1, $showAll = 200, $sliceStart = 5, $sliceEnd = 5, $percent = 20, $range = 10, $prompt = '') { - $gotopage = $prompt - . ' '; + $gotopage .= ' '; + return $gotopage; } // end function /** - * Generate navigation for a list + * Generate navigation for a list * - * @todo use $pos from $_url_params + * @todo use $pos from $_url_params * @uses $GLOBALS['strPageNumber'] * @uses range() - * @param integer number of elements in the list - * @param integer current position in the list - * @param array url parameters - * @param string script name for form target - * @param string target frame - * @param integer maximum number of elements to display from the list + * @param integer number of elements in the list + * @param integer current position in the list + * @param array url parameters + * @param string script name for form target + * @param string target frame + * @param integer maximum number of elements to display from the list * * @access public */ @@ -2191,7 +2192,7 @@ function PMA_listNavigator($count, $pos, $_url_params, $script, $frame, $max_cou . $caption2 . ''; } - echo '
' . "\n"; + echo "\n", '', "\n"; echo PMA_generate_common_hidden_inputs($_url_params); echo PMA_pageselector( $script . PMA_generate_common_url($_url_params) . '&', @@ -2213,7 +2214,7 @@ function PMA_listNavigator($count, $pos, $_url_params, $script, $frame, $max_cou $title4 = ''; } // end if... else... $_url_params['pos'] = $pos + $max_count; - echo '' . $caption3 . ''; $_url_params['pos'] = floor($count / $max_count) * $max_count;