diff --git a/ChangeLog b/ChangeLog index 8774a3415..0a6e9d1cc 100755 --- a/ChangeLog +++ b/ChangeLog @@ -17,6 +17,7 @@ $Source$ - clarified some variable names * db_sarch.php: fixed bug: Undefined variable: num_tables + * [really much files]: (not complete) PEAR coding standard 2006-01-16 Marc Delisle * server_privileges.php: typo diff --git a/db_datadict.php b/db_datadict.php index 0f0746c35..b16cd6c80 100644 --- a/db_datadict.php +++ b/db_datadict.php @@ -52,7 +52,7 @@ if ($cfgRelation['commwork']) { * Selects the database and gets tables names */ PMA_DBI_select_db($db); -$rowset = PMA_DBI_query('SHOW TABLES FROM ' . PMA_backquote($db) . ';', NULL, PMA_DBI_QUERY_STORE); +$rowset = PMA_DBI_query('SHOW TABLES FROM ' . PMA_backquote($db) . ';', null, PMA_DBI_QUERY_STORE); $count = 0; while ($row = PMA_DBI_fetch_assoc($rowset)) { @@ -128,7 +128,7 @@ while ($row = PMA_DBI_fetch_assoc($rowset)) { /** * Gets fields properties */ - $result = PMA_DBI_query('SHOW FIELDS FROM ' . PMA_backquote($table) . ';', NULL, PMA_DBI_QUERY_STORE); + $result = PMA_DBI_query('SHOW FIELDS FROM ' . PMA_backquote($table) . ';', null, PMA_DBI_QUERY_STORE); $fields_cnt = PMA_DBI_num_rows($result); // Check if we can use Relations (Mike Beck) if (!empty($cfgRelation['relation'])) { @@ -141,8 +141,7 @@ while ($row = PMA_DBI_fetch_assoc($rowset)) { } else { $have_rel = FALSE; } - } - else { + } else { $have_rel = FALSE; } // end if @@ -237,7 +236,7 @@ while ($row = PMA_DBI_fetch_assoc($rowset)) { xml:lang="en" dir="ltr"> >*/ ?> - + >*/ ?> 0) { foreach ($lines AS $lkey => $line) { //echo '

' . $line . '

'; - $inf = explode('|',$line); + $inf = explode('|', $line); if (!empty($inf[1]) && strlen(trim($inf[1])) > 0) { $qry = ' INSERT INTO @@ -125,14 +125,11 @@ if (isset($cfg['docSQLDir']) && !empty($cfg['docSQLDir'])) { if (empty($DOCUMENT_ROOT)) { if (!empty($_SERVER) && isset($_SERVER['DOCUMENT_ROOT'])) { $DOCUMENT_ROOT = $_SERVER['DOCUMENT_ROOT']; - } - else if (!empty($_ENV) && isset($_ENV['DOCUMENT_ROOT'])) { + } elseif (!empty($_ENV) && isset($_ENV['DOCUMENT_ROOT'])) { $DOCUMENT_ROOT = $_ENV['DOCUMENT_ROOT']; - } - else if (@getenv('DOCUMENT_ROOT')) { + } elseif (@getenv('DOCUMENT_ROOT')) { $DOCUMENT_ROOT = getenv('DOCUMENT_ROOT'); - } - else { + } else { $DOCUMENT_ROOT = '.'; } } // end if @@ -173,15 +170,13 @@ if (isset($cfg['docSQLDir']) && !empty($cfg['docSQLDir'])) { echo $strFileCouldNotBeRead; exit(); } - } - else { + } else { $sql_file_new = $tmp_subdir . basename($sql_file); move_uploaded_file($sql_file, $sql_file_new); $docsql_text = PMA_readFile($sql_file_new, $sql_file_compression); unlink($sql_file_new); } - } - else { + } else { // read from the normal upload dir $docsql_text = PMA_readFile($sql_file, $sql_file_compression); } @@ -228,7 +223,7 @@ if (isset($cfg['docSQLDir']) && !empty($cfg['docSQLDir'])) { */ ?> -
> + > diff --git a/db_details_structure.php b/db_details_structure.php index 061f09b30..fe7a71727 100644 --- a/db_details_structure.php +++ b/db_details_structure.php @@ -152,7 +152,7 @@ $row_count = 0; $hidden_fields = array(); $odd_row = true; foreach ( $tables as $keyname => $each_table ) { - if ( $each_table['TABLE_ROWS'] === NULL || $each_table['TABLE_ROWS'] < $GLOBALS['cfg']['MaxExactCount']) { + if ( $each_table['TABLE_ROWS'] === null || $each_table['TABLE_ROWS'] < $GLOBALS['cfg']['MaxExactCount']) { $each_table['TABLE_ROWS'] = PMA_countRecords( $db, $each_table['TABLE_NAME'], $return = true, $force_exact = true ); } @@ -452,21 +452,21 @@ echo '