diff --git a/ChangeLog b/ChangeLog index c48bdd1dc..c1ac6439b 100755 --- a/ChangeLog +++ b/ChangeLog @@ -9,6 +9,7 @@ $Source$ * libraries/display_tbl.lib.php: bug #985399 MIME-based in print view / need to select the pk * db_details_db_info.php: Undefined variable: db_is_information_schema + * tbl_properties.inc.php: bug #1305585 Add field(s) -> type ENTER 2005-11-06 Marc Delisle * lang/norwegian: Update, thanks to Sven-Erik Andersen diff --git a/tbl_properties.inc.php b/tbl_properties.inc.php index c83fcd82a..a53044225 100644 --- a/tbl_properties.inc.php +++ b/tbl_properties.inc.php @@ -11,9 +11,8 @@ PMA_checkParameters(array('db','table','action','num_fields')); require_once('./libraries/mysql_charsets.lib.php'); require_once('./libraries/storage_engines.lib.php'); -?> - - +if ($cfg['CtrlArrowsMoving']) { + ?> -= 40102) { ?> + = 40102) { + ?> - +
+ ?> +elseif ($action == 'tbl_addfield.php') { + ?> + ?> + ?> + ?> $o_fld_val) { - ?> + ?> - + ?> $o_fld_val) { - ?> + ?> - + ?> " /> = 40100) { } $header_cells[] = $strAttr; $header_cells[] = $strNull; -$header_cells[] = $strDefault . '**'; +$header_cells[] = $strDefault . '2'; $header_cells[] = $strExtra; @@ -128,11 +127,11 @@ $header_cells[] = $strExtra; // key fields, as tbl_addfield does. if (!$is_backup) { - $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strPrimary . '' : $strPrimary; - $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strIndex . '' : $strIndex; - $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strUnique . '' : $strUnique; + $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strPrimary . '' : $strPrimary; + $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strIndex . '' : $strIndex; + $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strUnique . '' : $strUnique; $header_cells[] = '---'; - $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strIdxFulltext . '' : $strIdxFulltext; + $header_cells[] = $cfg['PropertiesIconic'] ? '' . $strIdxFulltext . '' : $strIdxFulltext; } require_once('./libraries/relation.lib.php'); @@ -153,7 +152,7 @@ if ($cfgRelation['commwork']) { $header_cells[] = $strMIME_MIMEtype; $header_cells[] = $strMIME_transformation; - $header_cells[] = $strMIME_transformation_options . '***'; + $header_cells[] = $strMIME_transformation_options . '3'; } } @@ -166,7 +165,7 @@ if (isset($field_fulltext) && is_array($field_fulltext)) { } } -for ($i = 0 ; $i < $num_fields; $i++) { +for ( $i = 0 ; $i <= $num_fields; $i++ ) { $submit_null = FALSE; if (isset($regenerate) && $regenerate == TRUE) { // An error happened with previous inputs, so we will restore the data @@ -221,8 +220,6 @@ for ($i = 0 ; $i < $num_fields; $i++) { $row = $fields_meta[$i]; } - $bgcolor = ($i % 2) ? $cfg['BgcolorOne'] : $cfg['BgcolorTwo']; - // Cell index: If certain fields get left out, the counter shouldn't chage. $ci = 0; // Everytime a cell shall be left out the STRG-jumping feature, $ci_offset @@ -545,179 +542,162 @@ for ($i = 0 ; $i < $num_fields; $i++) { } } // end for -if ($cfg['DefaultPropDisplay'] == 'horizontal') { -?> - - - $header_val) { -?> - - - - $content_row) { - $i++; - echo "\n" . '' . "\n"; +if ( is_array( $content_cells ) && is_array( $header_cells ) ) { + // last row is for javascript insert + $empty_row = array_pop( $content_cells ); + + echo '
'; + if ( $cfg['DefaultPropDisplay'] == 'horizontal' ) { + ?> + + + + + + '; + $odd_row = ! $odd_row; - $bgcolor = ($i % 2) ? $cfg['BgcolorOne'] : $cfg['BgcolorTwo']; - - if (is_array($content_row)) { - foreach ($content_row AS $content_row_nr => $content_row_val) { -?> - - + + ' . "\n"; + echo ''; } - } -?> -
-
- - - $header_val) { - echo "\n" . '' . "\n"; -?> - - - + $odd_row = true; + foreach ( $header_cells as $header_val ) { + echo ''; + $odd_row = ! $odd_row; + ?> + + + + '; + $i++; + } + } + ?> +
+
' . "\n"; - $i++; - } - } -?> - -
-' . $content_row_val . ''; + } ?> + + - - + - - = 40100) { - echo ' ' . "\n" - . ' ' . "\n"; - } - } - echo "\n"; - ?> - - - + + if ( PMA_MYSQL_INT_VERSION >= 40100 ) { + echo ' ' . "\n" + . ' ' . "\n"; + } + ?> + + = 40100) { + if ( PMA_MYSQL_INT_VERSION >= 40100 ) { echo ' ' . "\n" . ' ' . "\n"; } - } - echo "\n"; - ?> - + ?> +
  ' . $strCollation . ': 
- -  ' . $strCollation . ': 
+    ' . "\n" . PMA_generateCharsetDropdownBox(PMA_CSDROPDOWN_COLLATION, 'tbl_collation', NULL, (isset($tbl_collation) ? $tbl_collation : NULL), FALSE, 3) . '

+} // end if ($action == 'tbl_create.php') +?> -' . "\n"; - echo ' ' . sprintf($strAddFields, '') . "\n"; - echo '  ' . "\n"; - echo '' . "\n"; - echo "
\n"; -} -?> - -
+
-
+ + + ' ); ?> + + onclick="return checkFormElementInRange(this.form, 'added_fields', '', 1)" + /> + +
- - - - - - - - - - +
+

1

+

2

-
- - - - - - - -3 ' . $strMIME_transformation_options_note . '

'; + echo '

'; + printf( $strMIME_transformation_note, + '', + '' ); + echo '

'; } -?> - -
- -
**  - -
***  - -
- ', '') . "\n"; ?> -
-
+?> +