diff --git a/ChangeLog b/ChangeLog index fffe6618a..cb1f696a0 100755 --- a/ChangeLog +++ b/ChangeLog @@ -20,6 +20,9 @@ $Source$ - moved styles into css - no need for javascript * relation.lib.php: uninitialized variable + * tbl_select.php, css/phpmyadmin.css.php: + - moved styles into css + - minor code improvements 2005-11-23 Michal Čihař * config.default.php, libraries/import/csv.php, libraries/import/ldi.php: diff --git a/css/phpmyadmin.css.php b/css/phpmyadmin.css.php index f4e175979..87ba64419 100644 --- a/css/phpmyadmin.css.php +++ b/css/phpmyadmin.css.php @@ -646,6 +646,9 @@ img.lightbulb { border: 0.1em solid red; } +#fieldset_select_fields { + float: left; +} '; - if ($propicon == 'both') { - $iconic_spacer = '
'; - } else { - $iconic_spacer = ''; - } - - $titles['Browse'] = $iconic_spacer . '' . $strBrowseForeignValues . ''; - - if ($propicon == 'both') { - $titles['Browse'] .= ' ' . $strBrowseForeignValues . '
'; + if ($GLOBALS['cfg']['PropertiesIconic'] === 'both') { + $titles['Browse'] .= $strBrowseForeignValues; } } else { - $titles['Browse'] = $strBrowseForeignValues; + $titles['Browse'] = $strBrowseForeignValues; } /** @@ -49,14 +43,14 @@ if (!isset($param) || $param[0] == '') { require_once('./tbl_properties_links.php'); if (!isset($goto)) { - $goto = $cfg['DefaultTabTable']; + $goto = $GLOBALS['cfg']['DefaultTabTable']; } // Defines the url to return to in case of error in the next sql statement $err_url = $goto . '?' . PMA_generate_common_url($db, $table); // Gets the list and number of fields - $result = PMA_DBI_query('SHOW' . (PMA_MYSQL_INT_VERSION >= 40100 ? ' FULL' : '') . ' FIELDS FROM ' . PMA_backquote($table) . ' FROM ' . PMA_backquote($db) . ';', NULL, PMA_DBI_QUERY_STORE); - $fields_cnt = PMA_DBI_num_rows($result); + $result = PMA_DBI_query('SHOW' . (PMA_MYSQL_INT_VERSION >= 40100 ? ' FULL' : '') . ' FIELDS FROM ' . PMA_backquote($table) . ' FROM ' . PMA_backquote($db) . ';', NULL, PMA_DBI_QUERY_STORE); + $fields_cnt = PMA_DBI_num_rows($result); // rabue: we'd better ensure, that all arrays are empty. $fields_list = $fields_null = $fields_type = $fields_collation = array(); while ($row = PMA_DBI_fetch_assoc($result)) { @@ -65,21 +59,21 @@ if (!isset($param) || $param[0] == '') { // reformat mysql query output - staybyte - 9. June 2001 if (strncasecmp($type, 'set', 3) == 0 || strncasecmp($type, 'enum', 4) == 0) { - $type = str_replace(',', ', ', $type); + $type = str_replace(',', ', ', $type); } else { - // strip the "BINARY" attribute, except if we find "BINARY(" because - // this would be a BINARY or VARBINARY field type + // strip the "BINARY" attribute, except if we find "BINARY(" because + // this would be a BINARY or VARBINARY field type if (!preg_match('@BINARY[\(]@i', $type)) { - $type = preg_replace('@BINARY@i', '', $type); + $type = preg_replace('@BINARY@i', '', $type); } - $type = preg_replace('@ZEROFILL@i', '', $type); - $type = preg_replace('@UNSIGNED@i', '', $type); + $type = preg_replace('@ZEROFILL@i', '', $type); + $type = preg_replace('@UNSIGNED@i', '', $type); $type = strtolower($type); } if (empty($type)) { - $type = ' '; + $type = ' '; } $fields_null[] = $row['Null']; $fields_type[] = $type; @@ -99,14 +93,14 @@ if (!isset($param) || $param[0] == '') { $foreigners = PMA_getForeigners($db, $table); ?>
- - - - - - - - - -
- - - - - - - - -
- -
- + + + - -
-
  - - - - - - - - - - - - - - - - -
- : -
- -
 
- -
- + + + + +
+ + +
+ +
+ +
-
- -
-
- - - - - - - - - - - - - - - - - - - - - - - +
 
- - -
- - - -
 
- ' . $strOr . ' ' . $strDoAQuery; ?> -
- - - - - = 40100 ? '' . "\n" : ''; ?> - - - + + +
+ + +
+ +
+ + +
+ + +
+ + + + + + +
+ +
+ +
+ ' . $strOr . ' ' . $strDoAQuery; ?> +
' . $strCollation . '
+ + + + = 40100 ? '' . "\n" : ''; ?> + + + + + - - - - = 40100 ? '' . "\n" : ''; ?> - + + + = 40100 ? '' . "\n" : ''; ?> + - + - + + + + + -
' . $strCollation . '
' . $fields_collation[$i] . ' -
' + . $fields_collation[$i] . ' - + + + $field = $fields_list[$i]; @@ -273,61 +239,66 @@ function PMA_tbl_select_operator(f, index, multiple) { // do not use require_once here require('./libraries/get_foreign.lib.php'); - echo "\n"; // we got a bug report: in some cases, even if $disp is true, // there are no rows, so we add a fetch_array if ($foreigners && isset($foreigners[$field]) && isset($disp_row) && is_array($disp_row)) { // f o r e i g n k e y s - echo ' ' . "\n"; // go back to first row // here, the 4th parameter is empty because there is no current // value of data for the dropdown (the search page initial values // are displayed empty) - echo PMA_foreignDropdown($disp_row, $foreign_field, $foreign_display, '', $cfg['ForeignKeyMaxLimit']); - echo ' ' . "\n"; - } else if (isset($foreign_link) && $foreign_link == true) { - ?> - + echo PMA_foreignDropdown($disp_row, $foreign_field, $foreign_display, + '', $GLOBALS['cfg']['ForeignKeyMaxLimit']); + echo ' ' . "\n"; + } elseif (isset($foreign_link) && $foreign_link == true) { + ?> + - ' . "\n"; + echo ' ' . "\n"; + echo ' ' . "\n"; } else { // o t h e r c a s e s - echo ' ' . "\n"; + echo ' ' . "\n"; } ?> - - - -
-
- - -
+ +
+ + +