From 1aaa89fa546e15fbe49bd196bfe1e42873bb4706 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Thu, 20 May 2004 16:14:13 +0000 Subject: [PATCH] Little code reorganistaion (RFE #957308), removed some remaining php3 compatibility code in SQL parser. --- ChangeLog | 4 ++ browse_foreigners.php | 2 +- css/phpmyadmin.css.php | 2 +- db_details.php | 6 +- db_details_importdocsql.php | 2 +- db_details_qbe.php | 14 ++--- db_details_structure.php | 28 ++++----- db_printview.php | 2 +- export.php | 2 +- header.inc.php | 8 +-- left.php | 18 +++--- libraries/auth/cookie.auth.lib.php | 4 +- libraries/charset_conversion.lib.php | 2 +- libraries/common.lib.php | 28 ++++----- libraries/db_config.lib.php | 4 +- libraries/dbg/profiling.php | 4 +- libraries/dbi/mysql.dbi.lib.php | 2 +- libraries/dbi/mysqli.dbi.lib.php | 4 +- libraries/display_export.lib.php | 18 +++--- libraries/display_tbl.lib.php | 32 +++++------ libraries/export/latex.php | 10 ++-- libraries/export/sql.php | 8 +-- libraries/fpdf/font/courier.php | 2 +- libraries/fpdf/fpdf.php | 20 +++---- libraries/grab_globals.lib.php | 4 +- libraries/ip_allow_deny.lib.php | 2 +- libraries/mysql_charsets.lib.php | 2 +- libraries/relation.lib.php | 6 +- libraries/select_lang.lib.php | 4 +- libraries/sqlparser.lib.php | 8 +-- libraries/transformations.lib.php | 2 +- libraries/transformations/overview.php | 4 +- main.php | 10 ++-- mult_submits.inc.php | 4 +- pdf_pages.php | 22 +++---- pdf_schema.php | 80 +++++++++++++------------- querywindow.php | 4 +- read_dump.php | 2 +- server_databases.php | 2 +- server_export.php | 2 +- server_processlist.php | 2 +- server_status.php | 4 +- tbl_addfield.php | 4 +- tbl_alter.php | 6 +- tbl_change.php | 6 +- tbl_create.php | 4 +- tbl_indexes.php | 18 +++--- tbl_move_copy.php | 8 +-- tbl_printview.php | 8 +-- tbl_properties.inc.php | 20 +++---- tbl_properties_export.php | 2 +- tbl_properties_operations.php | 4 +- tbl_properties_structure.php | 8 +-- tbl_query_box.php | 2 +- tbl_relation.php | 14 ++--- tbl_replace.php | 8 +-- tbl_row_delete.php | 4 +- transformation_wrapper.php | 4 +- 58 files changed, 256 insertions(+), 254 deletions(-) diff --git a/ChangeLog b/ChangeLog index 210f59016..89c784ba5 100755 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,10 @@ phpMyAdmin - Changelog $Id$ $Source$ +2004-05-20 Michal Čihař + * many files: Little code reorganistaion (RFE #957308), removed some + remaining php3 compatibility code in SQL parser. + 2004-05-20 Marc Delisle * pdf_schema.php: set contents page (first page)'s orientation to the same asked for the data dictionary diff --git a/browse_foreigners.php b/browse_foreigners.php index f8845aa8c..d384be9d2 100644 --- a/browse_foreigners.php +++ b/browse_foreigners.php @@ -153,7 +153,7 @@ if (isset($disp_row) && is_array($disp_row)) { $mysql_key_relrow = array(); $mysql_val_relrow = array(); $count = 0; - foreach($disp_row AS $disp_row_key => $relrow) { + foreach ($disp_row AS $disp_row_key => $relrow) { if ($foreign_display != FALSE) { $val = $relrow[$foreign_display]; } else { diff --git a/css/phpmyadmin.css.php b/css/phpmyadmin.css.php index e7c11fbf3..7bb2dd21c 100644 --- a/css/phpmyadmin.css.php +++ b/css/phpmyadmin.css.php @@ -224,7 +224,7 @@ button.mult_submit { div.warning { border: 1px solid red; - + background-image: url(../images/s_warn.png); background-repeat: no-repeat; background-position: 10px 50%; diff --git a/db_details.php b/db_details.php index 9a22ef98f..3ba3811ee 100644 --- a/db_details.php +++ b/db_details.php @@ -183,7 +183,7 @@ if (!empty($cfg['UploadDir'])) { // showing UploadDir Error at the end of all option for SQL-Queries $strErrorUploadDir = ' ' . "\n"; $strErrorUploadDir.= ' '; - if($cfg['PropertiesIconic']){ + if ($cfg['PropertiesIconic']){ $strErrorUploadDir.= ''; } $strErrorUploadDir.= ' ' . $strError . '' . "\n"; @@ -229,13 +229,13 @@ if ($cfg['Bookmark']['db'] && $cfg['Bookmark']['table']) { echo ' ' . $strBookmarkQuery . ': ' . "\n"; echo ' ' . "\n"; echo ' '; echo ' ' . $strVar . ' '; - if($cfg['ReplaceHelpImg']){ + if ($cfg['ReplaceHelpImg']){ echo '' . '' . $strDocu . ''; }else{ diff --git a/db_details_importdocsql.php b/db_details_importdocsql.php index 9eb97da99..af32ba7b3 100644 --- a/db_details_importdocsql.php +++ b/db_details_importdocsql.php @@ -64,7 +64,7 @@ if (isset($cfg['docSQLDir']) && !empty($cfg['docSQLDir'])) { } if (isset($lines) && is_array($lines) && count($lines) > 0) { - foreach($lines AS $lkey => $line) { + foreach ($lines AS $lkey => $line) { //echo '

' . $line . '

'; $inf = explode('|',$line); if (!empty($inf[1]) && strlen(trim($inf[1])) > 0) { diff --git a/db_details_qbe.php b/db_details_qbe.php index 12ab10b01..02a0e7eca 100644 --- a/db_details_qbe.php +++ b/db_details_qbe.php @@ -628,7 +628,7 @@ for ($x = 0; $x < $col; $x++) {
$val) { + foreach ($cfg['PDFPageSizes'] AS $key => $val) { echo '