From 1eadc0a41a8173e019ff92f3ed41ab0ca7dc3025 Mon Sep 17 00:00:00 2001 From: Sebastian Mendel Date: Thu, 21 Sep 2006 14:28:46 +0000 Subject: [PATCH] use @todo tag for todo items, to show up in generated documentation --- db_datadict.php | 22 +- db_operations.php | 11 +- libraries/Config.class.php | 4 +- libraries/Table.class.php | 48 +- libraries/auth/config.auth.lib.php | 10 +- libraries/check_user_privileges.lib.php | 24 +- libraries/common.lib.php | 60 +- libraries/config.default.php | 5 +- libraries/database_interface.lib.php | 26 +- libraries/db_table_exists.lib.php | 4 +- libraries/dbi/mysql.dbi.lib.php | 2 +- libraries/dbi/mysqli.dbi.lib.php | 6 +- libraries/display_tbl.lib.php | 21 +- libraries/export/pdf.php | 16 +- libraries/export/xls.php | 4 +- libraries/import.lib.php | 11 +- libraries/import/csv.php | 16 +- libraries/parse_analyze.lib.php | 11 +- libraries/select_server.lib.php | 4 +- libraries/session.inc.php | 4 +- libraries/sqlparser.lib.php | 618 ++++++------- libraries/tbl_properties_table_info.inc.php | 2 +- main.php | 6 +- pdf_schema.php | 4 +- server_collations.php | 4 +- server_privileges.php | 8 +- sql.php | 929 ++++++++++---------- tbl_alter.php | 12 +- tbl_change.php | 13 +- tbl_printview.php | 12 +- tbl_replace.php | 5 +- 31 files changed, 1019 insertions(+), 903 deletions(-) diff --git a/db_datadict.php b/db_datadict.php index b8bc9d76e..77de08ed2 100644 --- a/db_datadict.php +++ b/db_datadict.php @@ -42,7 +42,7 @@ if ($cfgRelation['commwork']) { */ if (is_array($comment)) { ?> -

+

+ ?> @@ -238,14 +238,16 @@ while ($row = PMA_DBI_fetch_assoc($rowset)) { // here, we have a TIMESTAMP that SHOW FULL FIELDS reports as having the // NULL attribute, but SHOW CREATE TABLE says the contrary. Believe // the latter. - // TODO: merge this logic with the one in tbl_properties_structure.php - // or move it in a function similar to PMA_DBI_get_columns_full() - // but based on SHOW CREATE TABLE because information_schema - // cannot be trusted in this case (MySQL bug) + /** + * @todo merge this logic with the one in tbl_properties_structure.php + * or move it in a function similar to PMA_DBI_get_columns_full() + * but based on SHOW CREATE TABLE because information_schema + * cannot be trusted in this case (MySQL bug) + */ if (!empty($analyzed_sql[0]['create_table_fields'][$field_name]['type']) && $analyzed_sql[0]['create_table_fields'][$field_name]['type'] == 'TIMESTAMP' && $analyzed_sql[0]['create_table_fields'][$field_name]['timestamp_not_null']) { $row['Null'] = ''; } - ?> + ?> xml:lang="en" dir="ltr"> >*/ ?> @@ -291,7 +293,7 @@ while ($row = PMA_DBI_fetch_assoc($rowset)) { } // end while PMA_DBI_free_result( $result ); $count++; - ?> + ?>
+ ?>
+?> - $vrow) { echo ' '; // find maximum upload size, based on field type - // FIXME: with functions this is not so easy, as you can basically process any data with function like MD5 + /** + * @todo with functions this is not so easy, as you can basically + * process any data with function like MD5 + */ $max_field_sizes = array( 'tinyblob' => '256', 'blob' => '65536', @@ -942,9 +947,9 @@ if (isset($primary_key)) { diff --git a/tbl_printview.php b/tbl_printview.php index 26154b2f3..3b3e3b9f3 100644 --- a/tbl_printview.php +++ b/tbl_printview.php @@ -110,7 +110,7 @@ foreach ($the_tables as $key => $table) { PMA_DBI_QUERY_STORE); $fields_cnt = PMA_DBI_num_rows($result); - + // We need this to correctly learn if a TIMESTAMP is NOT NULL, since // SHOW FULL FIELDS or INFORMATION_SCHEMA incorrectly says NULL // and SHOW CREATE TABLE says NOT NULL (tested @@ -220,10 +220,12 @@ foreach ($the_tables as $key => $table) { // here, we have a TIMESTAMP that SHOW FULL FIELDS reports as having the // NULL attribute, but SHOW CREATE TABLE says the contrary. Believe // the latter. - // TODO: merge this logic with the one in tbl_properties_structure.php - // or move it in a function similar to PMA_DBI_get_columns_full() - // but based on SHOW CREATE TABLE because information_schema - // cannot be trusted in this case (MySQL bug) + /** + * @todo merge this logic with the one in tbl_properties_structure.php + * or move it in a function similar to PMA_DBI_get_columns_full() + * but based on SHOW CREATE TABLE because information_schema + * cannot be trusted in this case (MySQL bug) + */ if (!empty($analyzed_sql[0]['create_table_fields'][$field_name]['type']) && $analyzed_sql[0]['create_table_fields'][$field_name]['type'] == 'TIMESTAMP' && $analyzed_sql[0]['create_table_fields'][$field_name]['timestamp_not_null']) { $row['Null'] = ''; } diff --git a/tbl_replace.php b/tbl_replace.php index cea073715..aa78eb561 100644 --- a/tbl_replace.php +++ b/tbl_replace.php @@ -276,8 +276,9 @@ if ($total_affected_rows != 0) { $message .= $last_message; if (!empty($warning_message)) { - // TODO: use a
in PMA_showMessage() - // for this part of the message + /** + * @todo use a
in PMA_showMessage() for this part of the message + */ $message .= '[br]' . $warning_message; }