diff --git a/ChangeLog b/ChangeLog index 448fc8786..4cb878cbe 100755 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,9 @@ phpMyAdmin - Changelog $Id$ $Source$ +2006-02-17 Sebastian Mendel + * libraries/sql_query_form.lib.php: + fixed bug #1433882 html special chars not escaped in query in querybox 2006-02-17 Marc Delisle * lang/*, db_details_structure.php: bug #1431352, no %d in strViewMaxExactCount diff --git a/libraries/sql_query_form.lib.php b/libraries/sql_query_form.lib.php index 535433443..7edc761e0 100644 --- a/libraries/sql_query_form.lib.php +++ b/libraries/sql_query_form.lib.php @@ -3,7 +3,7 @@ // vim: expandtab sw=4 ts=4 sts=4: /** * functions for displaying the sql query form - * + * * @usedby server_sql.php * @usedby db_details.php * @usedby tbl_properties.php @@ -11,12 +11,12 @@ * @usedby querywindow.php */ -require_once('./libraries/file_listing.php'); // used for file listing -require_once('./libraries/bookmark.lib.php'); // used for file listing +require_once './libraries/file_listing.php'; // used for file listing +require_once './libraries/bookmark.lib.php'; // used for file listing /** * prints the sql query boxes - * + * * @usedby server_sql.php * @usedby db_details.php * @usedby tbl_properties.php @@ -55,7 +55,7 @@ require_once('./libraries/bookmark.lib.php'); // used for file listing * @param boolean|string $query query to display in the textarea * or true to display last executed * @param boolean|string $display_tab sql|files|history|full|FALSE - * what part to display + * what part to display * false if not inside querywindow */ function PMA_sqlQueryForm($query = true, $display_tab = false) @@ -67,38 +67,38 @@ function PMA_sqlQueryForm($query = true, $display_tab = false) } else { $is_querywindow = true; } - + // query to show if (true === $query) { $query = empty($GLOBALS['sql_query']) ? '' : $GLOBALS['sql_query']; } - + // set enctype to multipart for file uploads if ($GLOBALS['is_upload']) { $enctype = ' enctype="multipart/form-data"'; } else { $enctype = ''; } - + $table = ''; $db = ''; if (! isset($GLOBALS['db']) || ! strlen($GLOBALS['db'])) { // prepare for server related - $goto = empty($GLOBALS['goto']) ? + $goto = empty($GLOBALS['goto']) ? 'server_sql.php' : $GLOBALS['goto']; } elseif (! isset($GLOBALS['table']) || ! strlen($GLOBALS['table'])) { // prepare for db related $db = $GLOBALS['db']; - $goto = empty($GLOBALS['goto']) ? + $goto = empty($GLOBALS['goto']) ? 'db_details.php' : $GLOBALS['goto']; } else { $table = $GLOBALS['table']; $db = $GLOBALS['db']; - $goto = empty($GLOBALS['goto']) ? + $goto = empty($GLOBALS['goto']) ? 'tbl_properties.php' : $GLOBALS['goto']; } - - + + // start output if ($is_querywindow) { ?> @@ -113,7 +113,7 @@ function PMA_sqlQueryForm($query = true, $display_tab = false) echo '
' . "\n"; } - + if ($is_querywindow) { echo '' ."\n"; @@ -125,23 +125,23 @@ function PMA_sqlQueryForm($query = true, $display_tab = false) echo '' . "\n" .PMA_generate_common_hidden_inputs($db, $table) . "\n" .'' . "\n" - .'' . "\n" - .'' . "\n" - .'' . "\n"; // display querybox if ($display_tab === 'full' || $display_tab === 'sql') { PMA_sqlQueryFormInsert($query, $is_querywindow); } - + // display uploads if ($display_tab === 'files' && $GLOBALS['is_upload']) { PMA_sqlQueryFormUpload(); } - + // Bookmark Support if ($display_tab === 'full' || $display_tab === 'history') { if (! empty( $GLOBALS['cfg']['Bookmark']) @@ -150,19 +150,19 @@ function PMA_sqlQueryForm($query = true, $display_tab = false) PMA_sqlQueryFormBookmark(); } } - + // Encoding setting form appended by Y.Kawada if (function_exists('PMA_set_enc_form')) { echo PMA_set_enc_form(' '); } - + echo '
' . "\n"; } /** * prints querybox fieldset * - * @usedby PMA_sqlQueryForm() + * @usedby PMA_sqlQueryForm() * @uses $GLOBALS['text_dir'] * @uses $GLOBALS['cfg']['TextareaAutoSelect'] * @uses $GLOBALS['cfg']['TextareaCols'] @@ -180,14 +180,14 @@ function PMA_sqlQueryForm($query = true, $display_tab = false) */ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) { - + // enable auto select text in textarea if ($GLOBALS['cfg']['TextareaAutoSelect']) { $auto_sel = ' onfocus="selectContent( this, sql_box_locked, true )"'; } else { $auto_sel = ''; } - + // enable locking if inside query window if ($is_querywindow) { $locking = ' onkeypress="document.sqlform.elements[\'LockFromUpdate\'].' @@ -195,7 +195,7 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) } else { $locking = ''; } - + $table = ''; $db = ''; $fields_list = array(); @@ -208,7 +208,7 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) // prepare for db related $db = $GLOBALS['db']; // if you want navigation: - $strDBLink = '' . "\n" .'
' . "\n" .'
' . "\n"; @@ -273,12 +273,12 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) echo '
' . "\n"; echo '
' . "\n" .'' . "\n"; + .' cols="' . $GLOBALS['cfg']['TextareaCols'] . '"' + .' rows="' . $GLOBALS['cfg']['TextareaRows'] . '"' + .' dir="' . $GLOBALS['text_dir'] . '"' + .$auto_sel . $locking . '>' . htmlspecialchars($query) . '' . "\n"; echo '
' . "\n"; - + if (count($fields_list)) { echo '
' . "\n" .'' . "\n" @@ -286,7 +286,7 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) .'size="' . ($GLOBALS['cfg']['TextareaRows'] - 2) . '" ' .'multiple="multiple" ondblclick="insertValueQuery()">' . "\n"; foreach ($fields_list as $field) { - echo '
' . "\n"; } - + echo '
' . "\n"; echo '
' . "\n"; - + if (! empty($GLOBALS['cfg']['Bookmark']) && $GLOBALS['cfg']['Bookmark']['db'] && $GLOBALS['cfg']['Bookmark']['table']) { @@ -322,13 +322,13 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false)
-
- @@ -336,11 +336,11 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false)
' . "\n"; echo '' . "\n" .'' . "\n"; - + echo '
' . "\n"; echo '
' . "\n"; if ($is_querywindow) { @@ -356,7 +356,7 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) echo '
' . "\n"; echo '' . "\n" - .'
' . "\n"; echo '' @@ -367,7 +367,7 @@ function PMA_sqlQueryFormInsert($query = '', $is_querywindow = false) /** * prints bookmark fieldset - * + * * @usedby PMA_sqlQueryForm() * @uses PMA_listBookmarks() * @uses $GLOBALS['db'] @@ -390,7 +390,7 @@ function PMA_sqlQueryFormBookmark() if (! $bookmark_list || count($bookmark_list) < 1) { return; } - + echo '
'; echo ''; echo $GLOBALS['strBookmarkQuery'] . '' . "\n"; @@ -398,7 +398,7 @@ function PMA_sqlQueryFormBookmark() echo '' . "\n"; echo '
' . "\n"; echo '
' . "\n"; @@ -435,7 +435,7 @@ function PMA_sqlQueryFormBookmark() echo '
' . "\n"; echo '
' . "\n"; echo '
' . "\n"; - + echo '
' . "\n"; echo ''; echo '
' . "\n"; @@ -444,7 +444,7 @@ function PMA_sqlQueryFormBookmark() /** * prints bookmark fieldset - * + * * @usedby PMA_sqlQueryForm() * @uses $GLOBALS['cfg']['GZipDump'] * @uses $GLOBALS['cfg']['BZipDump'] @@ -494,7 +494,7 @@ function PMA_sqlQueryFormUpload(){ // some browsers should respect this :) echo PMA_generateHiddenMaxFileSize($GLOBALS['max_upload_size']) . "\n"; echo ''; - + if ($files === FALSE) { $errors[$GLOBALS['strError']] = $GLOBALS['strWebServerUploadDirectoryError']; } elseif (!empty($files)) { @@ -534,7 +534,7 @@ function PMA_sqlQueryFormUpload(){ .'" />' . "\n"; echo '
' . "\n"; echo '
'; - + foreach ( $errors as $error => $message ) { echo '
' . $error . '
'; echo '
' . $message . '
';