From 51bc0252faffd623de3bb85e89f786fe2443dcb6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <michal@cihar.com>
Date: Tue, 30 May 2006 09:26:52 +0000
Subject: [PATCH] No need to grab all results to memory.

---
 ChangeLog              | 2 ++
 server_binlog.php      | 6 +++---
 server_processlist.php | 8 ++++----
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6604b3b34..7c3fff062 100755
--- a/ChangeLog
+++ b/ChangeLog
@@ -11,6 +11,8 @@ $Source$
     * libraries/plugin_interface.lib.php: Show that plugin has no option if it
       has only hidden inputs.
     * sql.php: Do not compare db if not defined.
+    * server_binlog.php, server_processlist.php: No need to grab all results
+      to memory.
 
 2006-05-29 Michal Čihař  <michal@cihar.com>
     * lang/galician: Update, thanks to Xosé Calvo - xosecalvo.
diff --git a/server_binlog.php b/server_binlog.php
index c51bdc1a8..d7cf8e2b4 100644
--- a/server_binlog.php
+++ b/server_binlog.php
@@ -55,9 +55,9 @@ if (!empty($log)) {
 }
 
 /**
- * Sends the query and buffers the result
+ * Sends the query
  */
-$serverProcesses = PMA_DBI_fetch_result($sql_query);
+$result = PMA_DBI_query($sql_query);
 
 PMA_showMessage($GLOBALS['strSuccess']);
 
@@ -85,7 +85,7 @@ PMA_showMessage($GLOBALS['strSuccess']);
 </tr>
 <?php
 $odd_row = true;
-foreach ($serverProcesses as $value) {
+while($value = PMA_DBI_fetch_assoc($result)) {
     if (empty($full) && PMA_strlen($value['Info']) > $GLOBALS['cfg']['LimitChars']) {
         $value['Info'] = PMA_substr($value['Info'], 0, $GLOBALS['cfg']['LimitChars']) . '...';
     }
diff --git a/server_processlist.php b/server_processlist.php
index ace89b263..f2305f520 100644
--- a/server_processlist.php
+++ b/server_processlist.php
@@ -38,10 +38,10 @@ echo '<h2>' . "\n"
 
 
 /**
- * Sends the query and buffers the result
+ * Sends the query
  */
 $sql_query = 'SHOW' . ( empty( $full ) ? '' : ' FULL' ) . ' PROCESSLIST';
-$serverProcesses = PMA_DBI_fetch_result( $sql_query );
+$result = PMA_DBI_query($sql_query);
 
 PMA_showMessage( $GLOBALS['strSuccess'] );
 
@@ -70,7 +70,7 @@ PMA_showMessage( $GLOBALS['strSuccess'] );
 <tbody>
 <?php
 $odd_row = true;
-foreach ( $serverProcesses AS $process ) {
+while($process = PMA_DBI_fetch_assoc($result)) {
     ?>
 <tr class="<?php echo $odd_row ? 'odd' : 'even'; ?>">
     <td><a href="./server_processlist.php?<?php echo $url_query . '&amp;kill=' . $process['Id']; ?>"><?php echo $strKill; ?></a></td>
@@ -95,4 +95,4 @@ foreach ( $serverProcesses AS $process ) {
  * Sends the footer
  */
 require_once('./libraries/footer.inc.php');
-?>
\ No newline at end of file
+?>