patch #3025161 [core] Prevent sending of unnecessary cookies

This commit is contained in:
Piotr Przybylski
2010-07-06 11:43:02 -04:00
committed by Marc Delisle
parent 11609bdf80
commit 573edc0329
2 changed files with 9 additions and 4 deletions

View File

@@ -84,6 +84,8 @@ $Id$
- bug #3004216 [CSS] Field attributes use inline CSS - bug #3004216 [CSS] Field attributes use inline CSS
- patch #2999595, rfe #2998130 [interface] Cleanup navigation frame. - patch #2999595, rfe #2998130 [interface] Cleanup navigation frame.
- [core] Update library PHPExcel to version 1.7.3c - [core] Update library PHPExcel to version 1.7.3c
- patch #3025161 [core] Prevent sending of unnecessary cookies,
thanks to Piotr Przybylski - crackpl
3.3.5.0 (not yet released) 3.3.5.0 (not yet released)
- patch #2932113 [information_schema] Slow export when having lots of - patch #2932113 [information_schema] Slow export when having lots of

View File

@@ -1086,10 +1086,13 @@ class PMA_Config
if ($validity == null) { if ($validity == null) {
$validity = 2592000; $validity = 2592000;
} }
if (strlen($value) && null !== $default && $value === $default if (strlen($value) && null !== $default && $value === $default) {
&& isset($_COOKIE[$cookie])) { // default value is used
// remove cookie, default value is used if (isset($_COOKIE[$cookie])) {
return $this->removeCookie($cookie); // remove cookie
return $this->removeCookie($cookie);
}
return false;
} }
if (! strlen($value) && isset($_COOKIE[$cookie])) { if (! strlen($value) && isset($_COOKIE[$cookie])) {