nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug #2961609 Potential information disclosure at login page

Browse Source
This commit is contained in:
Marc Delisle
2010-03-04 13:00:35 +00:00
parent 3ea273809a
commit 58d2c0a58c
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@@ -11,6 +11,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
- bug #2959746 [interface] Unknown table status: TABLE_TYPE - bug #2959746 [interface] Unknown table status: TABLE_TYPE
- bug #2953050 [export] export VIEW as SQL includes INSERT statement - bug #2953050 [export] export VIEW as SQL includes INSERT statement
- bug #2942032 [core] Cannot detect PmaAbsoluteUri correctly on Windows - bug #2942032 [core] Cannot detect PmaAbsoluteUri correctly on Windows
- bug #2961609 [auth] Potential information disclosure at login page
3.3.0.0 (not yet released) 3.3.0.0 (not yet released)
+ rfe #2308632 [edit] Use hex for (var)binary fields, + rfe #2308632 [edit] Use hex for (var)binary fields,

5
libraries/auth/cookie.auth.lib.php
View File

@@ -644,7 +644,6 @@ function PMA_auth_set_user()
* this function MUST exit/quit the application, * this function MUST exit/quit the application,
* currently doen by call to PMA_auth() * currently doen by call to PMA_auth()
* *
* @todo $php_errormsg is invalid here!? it will never be set in this scope
* @uses $GLOBALS['server'] * @uses $GLOBALS['server']
* @uses $GLOBALS['allowDeny_forbidden'] * @uses $GLOBALS['allowDeny_forbidden']
* @uses $GLOBALS['strAccessDenied'] * @uses $GLOBALS['strAccessDenied']
@@ -683,9 +682,7 @@ function PMA_auth_fails()
} }
} }
} elseif (PMA_DBI_getError()) { } elseif (PMA_DBI_getError()) {
$conn_error = PMA_sanitize(PMA_DBI_getError()); $conn_error = '#' . $GLOBALS['errno'] . ' ' . $GLOBALS['strCannotLogin'];
} elseif (isset($php_errormsg)) {
$conn_error = $php_errormsg;
} else { } else {
$conn_error = $GLOBALS['strCannotLogin']; $conn_error = $GLOBALS['strCannotLogin'];
} }