From 5dd2f3696de942a9f46cae835e9e43e2fe8ff9fa Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Wed, 29 Nov 2006 11:04:16 +0000
Subject: [PATCH] patch #1605032, undefined index

---
 ChangeLog                     | 2 ++
 libraries/display_tbl.lib.php | 2 +-
 sql.php                       | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 619dff787..774a34a32 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -7,6 +7,8 @@ $HeadURL$
 
 2006-11-29 Marc Delisle  <lem9@users.sourceforge.net>
     * lang/spanish update, thanks to Daniel Hinostroza
+    * sql.php, libraries/display_tbl.lib.php: patch #1605032, checks for
+      undefined index, thanks to Arpad Borsos
 
 2006-11-26 Marc Delisle  <lem9@users.sourceforge.net>
     * tbl_structure.php: bug #1602335, browse distinct values
diff --git a/libraries/display_tbl.lib.php b/libraries/display_tbl.lib.php
index c93972fef..9bbad7520 100644
--- a/libraries/display_tbl.lib.php
+++ b/libraries/display_tbl.lib.php
@@ -1106,7 +1106,7 @@ function PMA_displayTableBody(&$dt_result, &$is_display, $map, $analyzed_sql) {
                 }
             } // end if (1.2.1)
 
-            if ($table == $GLOBALS['cfg']['Bookmark']['table'] && $db == $GLOBALS['cfg']['Bookmark']['db'] && isset($row[1]) && isset($row[0])) {
+            if (isset($GLOBALS['cfg']['Bookmark']['table']) && isset($GLOBALS['cfg']['Bookmark']['db']) && $table == $GLOBALS['cfg']['Bookmark']['table'] && $db == $GLOBALS['cfg']['Bookmark']['db'] && isset($row[1]) && isset($row[0])) {
                 $bookmark_go = '<a href="import.php?'
                                 . PMA_generate_common_url($row[1], '')
                                 . '&amp;id_bookmark=' . $row[0]
diff --git a/sql.php b/sql.php
index 1170862a2..c7e6e3c2c 100644
--- a/sql.php
+++ b/sql.php
@@ -745,9 +745,9 @@ else {
         }
     } // End INDEX CHECK
 
-    // Bookmark Support if required
+    // Bookmark support if required
     if ($disp_mode[7] == '1'
-        && (isset($cfg['Bookmark']) && $cfg['Bookmark']['db'] && $cfg['Bookmark']['table'] && empty($id_bookmark))
+        && (isset($cfg['Bookmark']) && ! empty($cfg['Bookmark']['db']) && ! empty($cfg['Bookmark']['table']) && empty($id_bookmark))
         && !empty($sql_query)) {
         echo "\n";