nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Bug #3151925 Page selector dropdown broken with ORDER BY query

Browse Source 
- PMA_pageselector() had an unused parameter
This commit is contained in:
Marc Delisle
2011-01-08 15:14:00 -05:00
parent 45eb47fe14
commit 6094e6c644
4 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libraries/common.lib.php
View File

@@ -2173,9 +2173,7 @@ function PMA_buttonOrImage($button_name, $button_class, $image_name, $text,
/**
* Generate a pagination selector for browsing resultsets
*
* @todo $url is not javascript escaped!?
* @uses range()
* @param string URL for the JavaScript
* @param string Number of rows in the pagination set
* @param string current page number
* @param string number of total pages
@@ -2195,7 +2193,7 @@ function PMA_buttonOrImage($button_name, $button_class, $image_name, $text,
*
* @access public
*/
function PMA_pageselector($url, $rows, $pageNow = 1, $nbTotalPage = 1,
function PMA_pageselector($rows, $pageNow = 1, $nbTotalPage = 1,
$showAll = 200, $sliceStart = 5, $sliceEnd = 5, $percent = 20,
$range = 10, $prompt = '')
{
@@ -2320,7 +2318,6 @@ function PMA_listNavigator($count, $pos, $_url_params, $script, $frame, $max_cou
echo "\n", '<form action="./', basename($script), '" method="post" target="', $frame, '">', "\n";
echo PMA_generate_common_hidden_inputs($_url_params);
echo PMA_pageselector(
$script . PMA_generate_common_url($_url_params) . '&amp;',
$max_count,
floor(($pos + 1) / $max_count) + 1,
ceil($count / $max_count));

8
libraries/display_tbl.lib.php
View File

@@ -370,8 +370,6 @@ onsubmit="return (checkFormElementInRange(this, 'session_max_rows', '<?php echo
&nbsp;&nbsp;&nbsp;
</td>
<td>
<?php //<form> for keep the form alignment of button < and << ?>
<form action="none">
<?php
$_url_params = array(
'db' => $db,
@@ -379,9 +377,11 @@ onsubmit="return (checkFormElementInRange(this, 'session_max_rows', '<?php echo
'sql_query' => $sql_query,
'goto' => $goto,
);
//<form> to keep the form alignment of button < and <<
// and also to know what to execute when the selector changes
echo '<form action="sql.php' . PMA_generate_common_url($_url_params). '" method="post">';
echo PMA_pageselector(
'sql.php' . PMA_generate_common_url($_url_params) . PMA_get_arg_separator('js'),
$_SESSION['tmp_user_values']['max_rows'],
$_SESSION['tmp_user_values']['max_rows'],
$pageNow,
$nbTotalPage,
200,