diff --git a/ChangeLog b/ChangeLog index 0b69bfa6a..70cf10d49 100755 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,11 @@ phpMyAdmin - ChangeLog $Id$ $Source$ +2006-09-14 Michal Čihař + * db_details_structure.php: Fix table footer when MySQL does not support + collations (bug #1554885, patch #1557269, thanks to Isaac Bennetch - + ibennetch). + 2006-09-12 Marc Delisle * libraries/config.default.php, libraries/export/sql.php: bug #1556934, sql compatibility mode on export diff --git a/db_details_structure.php b/db_details_structure.php index 878aa5789..359a7ad31 100644 --- a/db_details_structure.php +++ b/db_details_structure.php @@ -408,14 +408,17 @@ if (!($cfg['PropertiesNumColumns'] > 1)) { echo ' ' . "\n" . ' ' .$default_engine . '' . "\n"; - // we got a case where $db_collation was empty - echo ' ' . "\n"; - if (! empty($db_collation)) { - echo ' ' . $db_collation - . ''; + // Have to account for old MySQL with no collation (bug 1554885) + if (PMA_MYSQL_INT_VERSION >= 40100) { + // we got a case where $db_collation was empty + echo ' ' . "\n"; + if (! empty($db_collation)) { + echo ' ' . $db_collation + . ''; + } + echo ''; } - echo ''; } if ($is_show_stats) {