From 62de51e0858dcac392c2c9812ffcc96f2ef7ea19 Mon Sep 17 00:00:00 2001 From: Garvin Hicking Date: Mon, 5 Jan 2004 16:10:15 +0000 Subject: [PATCH] reverted. see rfe 867284 --- ChangeLog | 2 ++ libraries/functions.js | 10 +++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8ce062ba4..f094e4277 100755 --- a/ChangeLog +++ b/ChangeLog @@ -6,6 +6,8 @@ $Id$ $Source$ 2004-01-05 Garvin Hicking + * libraries/functions.js: Reverted row marker patch. See RFE #867284 + for details. * libraries/display_tbl.lib.php, libraries/display_tbl_links.lib.php, libraries/functions.js: Upon clicking on a result row, de/activate the checkbox next to it. Only makes sense for horizontal mode. Can be diff --git a/libraries/functions.js b/libraries/functions.js index ddf43546b..0a6cf82a8 100644 --- a/libraries/functions.js +++ b/libraries/functions.js @@ -423,7 +423,11 @@ function setPointer(theRow, theRowNum, theAction, theDefaultColor, thePointerCol else if (theAction == 'click' && theMarkColor != '') { newColor = theMarkColor; marked_row[theRowNum] = true; - document.getElementById('id_rows_to_delete' + theRowNum).checked = true; + // Garvin: deactivated onclick marking of the checkbox because it's also executed + // when an action (like edit/delete) on a single item is performed. Then the checkbox + // would get deactived, even though we need it activated. Maybe there is a way + // to detect if the row was clicked, and not an item therein... + // document.getElementById('id_rows_to_delete' + theRowNum).checked = true; } } // 4.1.2 Current color is the pointer one @@ -435,7 +439,7 @@ function setPointer(theRow, theRowNum, theAction, theDefaultColor, thePointerCol else if (theAction == 'click' && theMarkColor != '') { newColor = theMarkColor; marked_row[theRowNum] = true; - document.getElementById('id_rows_to_delete' + theRowNum).checked = true; + // document.getElementById('id_rows_to_delete' + theRowNum).checked = true; } } // 4.1.3 Current color is the marker one @@ -447,7 +451,7 @@ function setPointer(theRow, theRowNum, theAction, theDefaultColor, thePointerCol marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum]) ? true : null; - document.getElementById('id_rows_to_delete' + theRowNum).checked = false; + // document.getElementById('id_rows_to_delete' + theRowNum).checked = false; } } // end 4