nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a loop to remove code duplication

Browse Source
This commit is contained in:
Herman van Rink
2011-04-25 14:19:43 +02:00
parent 0352d27db7
commit 6617a14297
1 changed files with 23 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
server_privileges.php
View File

@@ -509,6 +509,8 @@ function PMA_displayPrivTable($db = '*', $table = '*', $submit = TRUE)
// g l o b a l o r d b - s p e c i f i c // g l o b a l o r d b - s p e c i f i c
// //
$privTable_names = array(0 => __('Data'), 1 => __('Structure'), 2 => __('Administration'));
// d a t a // d a t a
$privTable[0] = array( $privTable[0] = array(
array('Select', 'SELECT', __('Allows reading data.')), array('Select', 'SELECT', __('Allows reading data.')),
@@ -582,59 +584,29 @@ function PMA_displayPrivTable($db = '*', $table = '*', $submit = TRUE)
. $GLOBALS['url_query'] . '" onclick="setCheckboxes(\'addUsersForm_' . $random_n . '\', false); return false;">' . $GLOBALS['url_query'] . '" onclick="setCheckboxes(\'addUsersForm_' . $random_n . '\', false); return false;">'
. __('Uncheck All') . '</a>)' . "\n" . __('Uncheck All') . '</a>)' . "\n"
. ' </legend>' . "\n" . ' </legend>' . "\n"
. ' <p><small><i>' . __(' Note: MySQL privilege names are expressed in English ') . '</i></small></p>' . "\n" . ' <p><small><i>' . __(' Note: MySQL privilege names are expressed in English ') . '</i></small></p>' . "\n";
. ' <fieldset>' . "\n"
. ' <legend>' . __('Data') . '</legend>' . "\n"; // Output the Global privilege tables
foreach ($privTable[0] as $priv) foreach($privTable as $i => $table) {
{ echo ' <fieldset>' . "\n"
echo ' <div class="item">' . "\n" . ' <legend>' . __($privTable_names[$i]) . '</legend>' . "\n";
. ' <input type="checkbox"' foreach ($table as $priv)
. (empty($GLOBALS['checkall']) ? '' : ' checked="checked"') {
. ' name="' . $priv[0] . '_priv" id="checkbox_' . $priv[0] echo ' <div class="item">' . "\n"
. '_priv" value="Y" ' . ' <input type="checkbox"'
. ($row[$priv[0] . '_priv'] == 'Y' ? 'checked="checked" ' : '') . (empty($GLOBALS['checkall']) ? '' : ' checked="checked"')
. 'title="' . $priv[2] . '"/>' . "\n" . ' name="' . $priv[0] . '_priv" id="checkbox_' . $priv[0]
. ' <label for="checkbox_' . $priv[0] . '_priv" value="Y" '
. '_priv"><tt><dfn title="' . $priv[2] . '">' . $priv[1] . ($row[$priv[0] . '_priv'] == 'Y' ? 'checked="checked" ' : '')
. '</dfn></tt></label>' . "\n" . 'title="' . $priv[2] . '"/>' . "\n"
. ' </div>' . "\n"; . ' <label for="checkbox_' . $priv[0]
} . '_priv"><tt><dfn title="' . $priv[2] . '">' . $priv[1]
echo ' </fieldset>' . "\n" . '</dfn></tt></label>' . "\n"
. ' <fieldset>' . "\n" . ' </div>' . "\n";
. ' <legend>' . __('Structure') . '</legend>' . "\n"; }
foreach ($privTable[1] as $priv) echo ' </fieldset>' . "\n";
{
echo ' <div class="item">' . "\n"
. ' <input type="checkbox"'
. (empty($GLOBALS['checkall']) ? '' : ' checked="checked"')
. ' name="' . $priv[0] . '_priv" id="checkbox_' . $priv[0]
. '_priv" value="Y" '
. ($row[$priv[0] . '_priv'] == 'Y' ? 'checked="checked" ' : '')
. 'title="' . $priv[2] . '"/>' . "\n"
. ' <label for="checkbox_' . $priv[0]
. '_priv"><tt><dfn title="' . $priv[2] . '">' . $priv[1]
. '</dfn></tt></label>' . "\n"
. ' </div>' . "\n";
}
echo ' </fieldset>' . "\n"
. ' <fieldset>' . "\n"
. ' <legend>' . __('Administration') . '</legend>' . "\n";
foreach ($privTable[2] as $priv)
{
echo ' <div class="item">' . "\n"
. ' <input type="checkbox"'
. (empty($GLOBALS['checkall']) ? '' : ' checked="checked"')
. ' name="' . $priv[0] . '_priv" id="checkbox_' . $priv[0]
. '_priv" value="Y" '
. ($row[$priv[0] . '_priv'] == 'Y' ? 'checked="checked" ' : '')
. 'title="' . $priv[2] . '"/>' . "\n"
. ' <label for="checkbox_' . $priv[0]
. '_priv"><tt><dfn title="' . $priv[2] . '">' . $priv[1]
. '</dfn></tt></label>' . "\n"
. ' </div>' . "\n";
} }
echo ' </fieldset>' . "\n";
// The "Resource limits" box is not displayed for db-specific privs // The "Resource limits" box is not displayed for db-specific privs
if ($db == '*') { if ($db == '*') {
echo ' <fieldset>' . "\n" echo ' <fieldset>' . "\n"