From 6de7cbca22c3853a0a214b93d1ba8a60751a4c4f Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Mon, 9 Oct 2006 12:39:08 +0000
Subject: [PATCH] bug 1562533, unbuffered queries

---
 ChangeLog                | 3 +++
 libraries/export/sql.php | 7 ++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index c13d525e6..d788945ef 100755
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,9 @@ phpMyAdmin - ChangeLog
 $Id$
 $Source$
 
+2006-10-09 Marc Delisle  <lem9@users.sourceforge.net>
+    * libraries/export/sql.php: bug #1562533, problems with unbuffered queries
+
 2006-10-07 Marc Delisle  <lem9@users.sourceforge.net>
     * scripts/create-release.sh: use lang-cleanup.sh from the kit,
       list all files, and allow non-anonymous access
diff --git a/libraries/export/sql.php b/libraries/export/sql.php
index 4a4fc51a3..e3c727bba 100644
--- a/libraries/export/sql.php
+++ b/libraries/export/sql.php
@@ -402,7 +402,12 @@ function PMA_getTableDef($db, $table, $crlf, $error_url, $show_dates = false)
         PMA_DBI_query('SET SQL_QUOTE_SHOW_CREATE = 0');
     }
 
-    $result = PMA_DBI_query('SHOW CREATE TABLE ' . PMA_backquote($db) . '.' . PMA_backquote($table), null, PMA_DBI_QUERY_UNBUFFERED);
+    // I don't see the reason why this unbuffered query could cause problems,
+    // because SHOW CREATE TABLE returns only one row, and we free the
+    // results below. Nonetheless, we got 2 user reports about this
+    // (see bug 1562533) so I remove the unbuffered mode.
+    //$result = PMA_DBI_query('SHOW CREATE TABLE ' . PMA_backquote($db) . '.' . PMA_backquote($table), null, PMA_DBI_QUERY_UNBUFFERED);
+    $result = PMA_DBI_query('SHOW CREATE TABLE ' . PMA_backquote($db) . '.' . PMA_backquote($table));
     if ($result != FALSE && ($row = PMA_DBI_fetch_row($result))) {
         $create_query = $row[1];
         unset($row);