diff --git a/ChangeLog b/ChangeLog index 03197d845..944449a61 100644 --- a/ChangeLog +++ b/ChangeLog @@ -111,6 +111,7 @@ $Id$ - rfe #806035, #686260 [relations] Export relations to Dia, SVG and others + [interface] Added charts to status tab, profiling page and query results + [interface] AJAXification on various pages +- [core] Remove last remaining parts of profiling code which was removed in 2006. 3.3.7.0 (not yet released) - patch #3050492 [PDF scratchboard] Cannot drag table box to the edge after diff --git a/Documentation.html b/Documentation.html index 2ee298ba3..5a31aedfe 100644 --- a/Documentation.html +++ b/Documentation.html @@ -2274,30 +2274,6 @@ setfacl -d -m "g:www-data:rwx" tmp Enable logging queries and execution times to be displayed in the bottom of main page (right frame). -
$cfg['DBG']['php'] boolean
-
DEVELOPERS ONLY!
- Enable the DBG extension for debugging phpMyAdmin. Required for profiling - the code.
- For help in setting up your system to this, see the - Developers section.
- -
$cfg['DBG']['profile']['enable'] boolean
-
DEVELOPERS ONLY!
- Enable profiling support for phpMyAdmin. This will append a chunk of data - to the end of every page displayed in the main window with profiling - statistics for that page.
- You may need to increase the maximum execution time for this to - complete successfully.Profiling was removed from the code for - version 2.9.0 due to licensing issues.
- -
$cfg['DBG']['profile']['threshold'] float (units in milliseconds)
-
DEVELOPERS ONLY!
- When profiling data is displayed, this variable controls the threshold of - display for any profiling data, based on the average time each time has - taken. If it is over the threshold it is displayed, otherwise it is not - displayed. This takes a value in milliseconds. In most cases you don't need - to edit this.
-
$cfg['ColumnTypes'] array
All possible types of a MySQL column. In most cases you don't need to edit this.
diff --git a/libraries/config.default.php b/libraries/config.default.php index b637e58a2..466dc2c0d 100644 --- a/libraries/config.default.php +++ b/libraries/config.default.php @@ -2653,29 +2653,6 @@ $cfg['DBG'] = array(); */ $cfg['DBG']['sql'] = false; -/** - * Make the DBG stuff available - * To use the following, please install the DBG extension from http://dd.cron.ru/dbg/ - * - * @global boolean $cfg['DBG']['php'] - */ -$cfg['DBG']['php'] = false; - -/** - * Produce profiling results of PHP - * - * @global boolean $cfg['DBG']['profile']['enable'] - */ -$cfg['DBG']['profile']['enable'] = false; - -/** - * Threshold of long running code to display - * Anything below the threshold is not displayed - * - * @global float $cfg['DBG']['profile']['threshold'] - */ -$cfg['DBG']['profile']['threshold'] = 0.5; - /******************************************************************************* * MySQL settings diff --git a/libraries/config/messages.inc.php b/libraries/config/messages.inc.php index a771ee611..33a4f315c 100644 --- a/libraries/config/messages.inc.php +++ b/libraries/config/messages.inc.php @@ -40,7 +40,6 @@ $strConfigConfigurationFile = __('Configuration file'); $strConfigConfirm_desc = __('Whether a warning ("Are your really sure...") should be displayed when you\'re about to lose data'); $strConfigConfirm_name = __('Confirm DROP queries'); $strConfigCtrlArrowsMoving_name = __('Field navigation using Ctrl+Arrows'); -$strConfigDBG_php_name = __('Debug PHP'); $strConfigDBG_sql_name = __('Debug SQL'); $strConfigDefaultDisplay_name = __('Default display direction'); $strConfigDefaultPropDisplay_desc = __('[kbd]horizontal[/kbd], [kbd]vertical[/kbd] or a number that indicates maximum number for which vertical model is used'); diff --git a/libraries/config/setup.forms.php b/libraries/config/setup.forms.php index ebaaf2792..48d195aca 100644 --- a/libraries/config/setup.forms.php +++ b/libraries/config/setup.forms.php @@ -118,8 +118,7 @@ $forms['Features']['Developer'] = array( 'UserprefsDeveloperTab', 'Error_Handler/display', 'Error_Handler/gather', - 'DBG/sql', - 'DBG/php'); + 'DBG/sql'); $forms['Features']['Other_core_settings'] = array( 'NaturalOrder', 'InitialSlidersState', @@ -370,4 +369,4 @@ $forms['Export']['Texy'] = array('Export' => array( ':group:' . __('Data'), 'texytext_null', 'texytext_columns')); -?> \ No newline at end of file +?> diff --git a/libraries/config/user_preferences.forms.php b/libraries/config/user_preferences.forms.php index 3f4814fd8..a82a3511c 100644 --- a/libraries/config/user_preferences.forms.php +++ b/libraries/config/user_preferences.forms.php @@ -51,8 +51,7 @@ $forms['Features']['Warnings'] = array( $forms['Features']['Developer'] = array( 'Error_Handler/display', 'Error_Handler/gather', - 'DBG/sql', - 'DBG/php'); + 'DBG/sql'); $forms['Sql_queries']['Sql_queries'] = array( 'ShowSQL', 'Confirm', @@ -272,4 +271,4 @@ $forms['Export']['Texy'] = array( ':group:' . __('Data'), 'Export/texytext_null', 'Export/texytext_columns'); -?> \ No newline at end of file +?> diff --git a/libraries/dbg/setup.php b/libraries/dbg/setup.php deleted file mode 100644 index 7b80ce2d1..000000000 --- a/libraries/dbg/setup.php +++ /dev/null @@ -1,31 +0,0 @@ -addParam(sprintf('[a@http://php.net/%1$s@Documentation][em]%1$s[/em][/a]', 'dbg')); - $message->addMessage('', false); - $message->addString(__('Documentation')); - $message->addMessage('', false); - $message->display(); - } else { - $GLOBALS['DBG'] = true; - } -} -?> diff --git a/libraries/footer.inc.php b/libraries/footer.inc.php index a752d6c57..f5e6e9872 100644 --- a/libraries/footer.inc.php +++ b/libraries/footer.inc.php @@ -29,8 +29,6 @@ * @uses $GLOBALS['userlink'] to close it * @uses $cfg['Server']['user'] * @uses $cfg['NavigationBarIconic'] - * @uses $cfg['DBG']['enable'] - * @uses $cfg['DBG']['profile']['enable'] * @uses $cfg['MaxCharactersInDisplayedSQL'] * @uses PMA_isValid() * @uses PMA_setHistory() @@ -202,25 +200,6 @@ if (! $GLOBALS['is_ajax_request'] && file_exists(CUSTOM_FOOTER_FILE)) { require CUSTOM_FOOTER_FILE; } - -/** - * Generates profiling data if requested - */ - -// profiling deactivated due to licensing issues -if (! empty($GLOBALS['cfg']['DBG']['php']) - && ! empty($GLOBALS['cfg']['DBG']['profile']['enable'])) { - //run the basic setup code first - require_once './libraries/dbg/setup.php'; - //if the setup ran fine, then do the profiling - /* - if (! empty($GLOBALS['DBG'])) { - require_once './libraries/dbg/profiling.php'; - dbg_dump_profiling_results(); - } - */ -} - /** * If we are in an AJAX request, we do not need to generate the closing tags for * body and html. diff --git a/libraries/user_preferences.inc.php b/libraries/user_preferences.inc.php index b86e4a144..e173d55b3 100644 --- a/libraries/user_preferences.inc.php +++ b/libraries/user_preferences.inc.php @@ -48,21 +48,6 @@ if (!empty($_GET['saved'])) { $message->display(); } -// debug info -if ($cfg['DBG']['php']) { - $arr = ConfigFile::getInstance()->getConfigArray(); - $arr2 = array(); - foreach ($arr as $k => $v) { - $arr2[] = "$k " . var_export($v, true); - } - $arr2 = implode(', ', $arr2); - $arr2 .= '
Blacklist: ' . (empty($cfg['UserprefsDisallow']) - ? 'empty' - : implode(', ', $cfg['UserprefsDisallow'])); - $msg = PMA_Message::notice('Settings: ' . $arr2); - $msg->display(); -} - // warn about using session storage for settings $cfgRelation = PMA_getRelationsParam(); if (!$cfgRelation['userconfigwork']) { diff --git a/libraries/user_preferences.lib.php b/libraries/user_preferences.lib.php index c513a19a3..bf84b25dc 100644 --- a/libraries/user_preferences.lib.php +++ b/libraries/user_preferences.lib.php @@ -164,7 +164,6 @@ function PMA_apply_userprefs(array $config_data) $blacklist['Error_Handler/display'] = true; $blacklist['Error_Handler/gather'] = true; $blacklist['DBG/sql'] = true; - $blacklist['DBG/php'] = true; } $whitelist = array_flip(PMA_read_userprefs_fieldnames()); // whitelist some additional fields which are custom handled @@ -313,4 +312,4 @@ function PMA_userprefs_autoload_header() \ No newline at end of file +?>