nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug #3127904, Close all opened round brackets indents

Browse Source
This commit is contained in:
Dieter Adriaenssens
2010-12-13 21:18:33 +01:00
parent b6f717a602
commit 8afdcbe2b8
2 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@@ -15,6 +15,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
thanks to Craig Duncan - duncan3dc thanks to Craig Duncan - duncan3dc
- bug #3112614 [pdf schema] Scratchboard for PDF pages not working - bug #3112614 [pdf schema] Scratchboard for PDF pages not working
- bug #3125606 [parser] Query for table "level" causes strange display - bug #3125606 [parser] Query for table "level" causes strange display
- bug #3127904 [parser] Close all opened round brackets indents
3.3.8.1 (2010-11-29) 3.3.8.1 (2010-11-29)
- bug #3115519 (private) [security] XSS on db search, see PMASA-2010-8 - bug #3115519 (private) [security] XSS on db search, see PMASA-2010-8

31
libraries/sqlparser.lib.php
View File

@@ -2165,7 +2165,6 @@ if (! defined('PMA_MINIMUM_COMMON')) {
// DEBUG echo "Loop format <strong>" . $arr[$i]['data'] . "</strong> " . $arr[$i]['type'] . "<br />"; // DEBUG echo "Loop format <strong>" . $arr[$i]['data'] . "</strong> " . $arr[$i]['type'] . "<br />";
$before = ''; $before = '';
$after = ''; $after = '';
$indent = 0;
// array_shift($typearr); // array_shift($typearr);
/* /*
0 prev2 0 prev2
@@ -2265,17 +2264,20 @@ if (! defined('PMA_MINIMUM_COMMON')) {
} }
break; break;
case 'punct_bracket_close_round': case 'punct_bracket_close_round':
$bracketlevel--; // only close bracket level when it was opened before
if ($infunction == TRUE) { if ($bracketlevel > 0) {
$functionlevel--; $bracketlevel--;
$after .= ' '; if ($infunction == TRUE) {
$before .= ' '; $functionlevel--;
} else { $after .= ' ';
$indent--; $before .= ' ';
$before .= ($mode != 'query_only' ? '</div>' : ' '); } else {
} $indent--;
$infunction = ($functionlevel > 0) ? TRUE : FALSE; $before .= ($mode != 'query_only' ? '</div>' : ' ');
break; }
$infunction = ($functionlevel > 0) ? TRUE : FALSE;
}
break;
case 'alpha_columnType': case 'alpha_columnType':
if ($typearr[3] == 'alpha_columnAttrib') { if ($typearr[3] == 'alpha_columnAttrib') {
$after .= ' '; $after .= ' ';
@@ -2466,6 +2468,11 @@ if (! defined('PMA_MINIMUM_COMMON')) {
} }
$str .= $after; $str .= $after;
} // end for } // end for
// close unclosed indent levels
while ($indent > 0) {
$indent--;
$str .= ($mode != 'query_only' ? '</div>' : ' ');
}
if ($mode=='color') { if ($mode=='color') {
$str .= '</span>'; $str .= '</span>';
} }