From 8eec123dd8f45a45b7324ba0e89b0da0e688badd Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Fri, 8 Oct 2010 12:53:06 -0400 Subject: [PATCH] we should not prefix a js variable name with dollar sign unless it is a jQuery object --- js/functions.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/js/functions.js b/js/functions.js index 03cf18690..57bbd882c 100644 --- a/js/functions.js +++ b/js/functions.js @@ -1722,23 +1722,23 @@ function changeMIMEType(db, table, reference, mime_type) * Jquery Coding for inline editing SQL_QUERY */ $(document).ready(function(){ - var $oldText,$db,$table,$token,$sql_query; - $oldText=$(".inner_sql").html(); + var oldText,db,table,token,sql_query; + oldText=$(".inner_sql").html(); $("#inline_edit").click(function(){ - $db=$("input[name='db']").val(); - $table=$("input[name='table']").val(); - $token=$("input[name='token']").val(); - $sql_query=$("input[name='sql_query']").val(); - $(".inner_sql").replaceWith(""); + db=$("input[name='db']").val(); + table=$("input[name='table']").val(); + token=$("input[name='token']").val(); + sql_query=$("input[name='sql_query']").val(); + $(".inner_sql").replaceWith(""); return false; }); $("#btnSave").live("click",function(){ - window.location.replace("import.php?db="+$db+"&table="+$table+"&sql_query="+$("#sql_query_edit").val()+"&show_query=1&token="+$token+""); + window.location.replace("import.php?db=" + db +"&table=" + table + "&sql_query=" + $("#sql_query_edit").val()+"&show_query=1&token=" + token + ""); }); $("#btnDiscard").live("click",function(){ - $(".sql").html(""+$oldText+""); + $(".sql").html("" + oldText + ""); }); $('.sqlbutton').click(function(evt){