From 94c2f864ae1dbe9efcf408e64b051621e7335643 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Thu, 21 Jan 2010 11:18:18 +0000 Subject: [PATCH] [core] Remove config data from session as it brings chicken-egg problem. Configuration data stores PmaAbsoluteUri, which should be accessible before initiating session. Otherwise there is no way to make PmaAbsoluteUri work. PmaAbsoluteUri is needed at least for reverse proxy setups, for example http webserver running behind https proxy. --- ChangeLog | 1 + browse_foreigners.php | 2 +- bs_change_mime_type.php | 2 +- bs_disp_as_mime_type.php | 2 +- bs_play_media.php | 2 +- db_operations.php | 8 +- db_structure.php | 2 +- export.php | 6 +- libraries/Config.class.php | 87 +++++++++-- libraries/File.class.php | 6 +- libraries/Theme_Manager.class.php | 6 +- libraries/auth/config.auth.lib.php | 2 +- libraries/auth/cookie.auth.lib.php | 30 ++-- libraries/blobstreaming.lib.php | 20 +-- libraries/common.inc.php | 146 +++++++++--------- libraries/common.lib.php | 4 +- libraries/core.lib.php | 73 +-------- libraries/display_tbl.lib.php | 2 +- libraries/header_meta_style.inc.php | 2 +- libraries/header_printview.inc.php | 2 +- libraries/session.inc.php | 8 +- navigation.php | 2 +- setup/index.php | 4 +- setup/lib/ConfigFile.class.php | 2 +- setup/lib/common.inc.php | 2 +- setup/lib/index.lib.php | 2 +- tbl_change.php | 4 +- tbl_replace.php | 2 +- test/theme.php | 2 +- .../darkblue_orange/css/theme_right.css.php | 2 +- themes/original/css/theme_left.css.php | 2 +- themes/original/css/theme_right.css.php | 2 +- user_password.php | 4 +- webapp.php | 2 +- 34 files changed, 223 insertions(+), 222 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6e1324437..a57f4b40c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA + rfe #2838080 [interface] Show warning when javascript is disabled. + rfe #2823707 [edit] Call UUID function separately to show it in insert. + rfe #2420684 [export] Allow export of timestamps in UTC. ++ [core] Remove config data from session as it brings chicken-egg problem. 3.3.0.0 (not yet released) + rfe #2308632 [edit] Use hex for (var)binary fields, diff --git a/browse_foreigners.php b/browse_foreigners.php index b177a16a8..b1f208365 100644 --- a/browse_foreigners.php +++ b/browse_foreigners.php @@ -95,7 +95,7 @@ if (is_array($foreignData['disp_row'])) { phpMyAdmin + href="phpmyadmin.css.php?&js_frame=right&nocache=getThemeUniqueValue(); ?>" /> -

phpMyAdmin get('PMA_VERSION'); ?> setup

+

phpMyAdmin get('PMA_VERSION'); ?> setup