From 94c4d3c23ee27eca5878205856f34a26e1b3bfea Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Sun, 12 Apr 2009 10:43:43 +0000 Subject: [PATCH] bug #2634827 [import] Using DELIMITER ends with infinite cycle --- ChangeLog | 1 + libraries/import/sql.php | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/ChangeLog b/ChangeLog index 125dc10ef..5080139ec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -25,6 +25,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA - bug #2724844 Add Fields: Add index is missing quotes thanks to Luke Armstrong - bug #2740550 [interface] Using textarea CharEditing drops default values +- bug #2634827 [import] Using DELIMITER ends with infinite cycle 3.1.3.1 (2009-03-24) - [security] HTTP Response Splitting and file inclusion vulnerabilities diff --git a/libraries/import/sql.php b/libraries/import/sql.php index 6a6e76e35..c383d96ca 100644 --- a/libraries/import/sql.php +++ b/libraries/import/sql.php @@ -89,6 +89,11 @@ while (!($GLOBALS['finished'] && $i >= $len) && !$error && !$timeout_passed) { // Current length of our buffer $len = strlen($buffer); + // Avoid endless loop in case of missing last newline + if ($GLOBALS['finished'] && $buffer[$len - 1] != "\n") { + $buffer .= "\n"; + } + // Grab some SQL queries out of it while ($i < $len) { $found_delimiter = false;