From 9a4b524db73ac767a00251c51b45c04f90c5c489 Mon Sep 17 00:00:00 2001
From: ninadsp <ninadsp16289@gmail.com>
Date: Mon, 28 Jun 2010 01:59:52 +0530
Subject: [PATCH] Hacked the PMA_generate_slider_effect() code to work with
 jQuery. Ajax queries were failing due to the use of document.write(). Need to
 find a better solution with $.append()

---
 libraries/common.lib.php | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libraries/common.lib.php b/libraries/common.lib.php
index 77fa606fb..e12df7cd1 100755
--- a/libraries/common.lib.php
+++ b/libraries/common.lib.php
@@ -2551,10 +2551,16 @@ function PMA_generate_slider_effect($id, $message)
         echo '<div id="' . $id . '">';
         return;
     }
+    /**
+     * Bad hack on the next line. document.write() conflicts with jQuery, hence,
+     * opening the <div> with PHP itself instead of JavaScript.
+     *
+     * @todo find a better solution that uses $.append(), the recommended method
+     */
     ?>
+<div id="<?php echo $id; ?>" <?php echo $GLOBALS['cfg']['InitialSlidersState'] == 'closed' ? ' style="display: none; overflow:auto;"' : ''; ?>>
     <script type="text/javascript">
 // <![CDATA[
-    document.write('<div id="<?php echo $id; ?>" <?php echo $GLOBALS['cfg']['InitialSlidersState'] == 'closed' ? ' style="display: none; overflow:auto;"' : ''; ?>>');
 
     function PMA_set_status_label_<?php echo $id; ?>() {
         if ($('#<?php echo $id; ?>').css('display') == 'none') {