nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug #1910485 [core] Unsetting the whitelist during the loop

Browse Source
This commit is contained in:
Marc Delisle
2008-03-11 16:57:55 +00:00
parent 997e6587ba
commit a018a82b0a
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ChangeLog
View File

@@ -12,6 +12,8 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
- bug [lang] catalan wrong accented characters - bug [lang] catalan wrong accented characters
- bug #1893034 [Export] SET NAMES for importing with command-line client - bug #1893034 [Export] SET NAMES for importing with command-line client
+ [lang] Russian update, thanks to Victor Volkov + [lang] Russian update, thanks to Victor Volkov
- bug #1910485 [core] Unsetting the whitelist during the loop,
thanks to Jeroen Vrijkorte - jv_map
2.11.5.0 (2008-03-01) 2.11.5.0 (2008-03-01)
- bug #1862661 [GUI] Warn about rename deleting database - bug #1862661 [GUI] Warn about rename deleting database

6
libraries/common.inc.php
View File

@@ -129,6 +129,7 @@ foreach ($GLOBALS as $key => $dummy) {
die('numeric key detected'); die('numeric key detected');
} }
} }
unset($dummy);
/** /**
* PATH_INFO could be compromised if set, so remove it from PHP_SELF * PATH_INFO could be compromised if set, so remove it from PHP_SELF
@@ -147,7 +148,8 @@ $PMA_PHP_SELF = htmlspecialchars($PMA_PHP_SELF);
/** /**
* just to be sure there was no import (registering) before here * just to be sure there was no import (registering) before here
* we empty the global space * we empty the global space (but avoid unsetting $variables_list
* and $key in the foreach(), we still need them!)
*/ */
$variables_whitelist = array ( $variables_whitelist = array (
'GLOBALS', 'GLOBALS',
@@ -160,6 +162,8 @@ $variables_whitelist = array (
'_COOKIE', '_COOKIE',
'_SESSION', '_SESSION',
'PMA_PHP_SELF', 'PMA_PHP_SELF',
'variables_whitelist',
'key'
); );
foreach (get_defined_vars() as $key => $value) { foreach (get_defined_vars() as $key => $value) {