From a064d0cf9c5f328ea10a909381d916cfcd22cc40 Mon Sep 17 00:00:00 2001
From: Sebastian Mendel <cybot_tm@users.sourceforge.net>
Date: Tue, 4 Sep 2007 13:45:07 +0000
Subject: [PATCH] guess url param separator only once; optionally encode it;

---
 libraries/url_generating.lib.php | 44 ++++++++++++++++++++++----------
 1 file changed, 30 insertions(+), 14 deletions(-)

diff --git a/libraries/url_generating.lib.php b/libraries/url_generating.lib.php
index 2b137aa5a..5fe8505b9 100644
--- a/libraries/url_generating.lib.php
+++ b/libraries/url_generating.lib.php
@@ -134,7 +134,7 @@ function PMA_generate_common_hidden_inputs($db = '', $table = '', $indent = 0, $
  *
  * @author  nijel
  */
-function PMA_generate_common_url ($db = '', $table = '', $delim = '&amp;')
+function PMA_generate_common_url($db = '', $table = '', $delim = '&amp;')
 {
     if (is_array($db)) {
         $params =& $db;
@@ -200,22 +200,38 @@ function PMA_generate_common_url ($db = '', $table = '', $delim = '&amp;')
 /**
  * Returns url separator
  *
- * @return  string   character used for separating url parts
- *
+ * @uses    ini_get()
+ * @uses    strpos()
+ * @uses    strlen()
+ * @param   string  whether to encode separator or not, currently 'none' or 'html'
+ * @return  string  character used for separating url parts usally ; or &
  * @access  public
- *
  * @author  nijel
  */
-function PMA_get_arg_separator() {
-    // use seperators defined by php, but prefer ';'
-    // as recommended by W3C
-    $php_arg_separator_input = ini_get('arg_separator.input');
-    if (strpos($php_arg_separator_input, ';') !== false) {
-        return ';';
-    } elseif (strlen($php_arg_separator_input) > 0) {
-        return $php_arg_separator_input{0};
-    } else {
-        return '&';
+function PMA_get_arg_separator($encoded = 'none')
+{
+    static $separator = null;
+
+    if (null === $separator) {
+        // use seperators defined by php, but prefer ';'
+        // as recommended by W3C
+        $php_arg_separator_input = ini_get('arg_separator.input');
+        if (strpos($php_arg_separator_input, ';') !== false) {
+            $separator = ';';
+        } elseif (strlen($php_arg_separator_input) > 0) {
+            $separator = $php_arg_separator_input{0};
+        } else {
+            $separator = '&';
+        }
+    }
+
+    switch ($encoded) {
+        case 'html':
+            return htmlentities($separator);
+            break;
+        case 'none' :
+        default :
+            return $separator;
     }
 }